Re: [PATCH]: Call dbd_setup() for all virtual hosts or create mutex inmod_dbd.c

[Bojan Smojver <bo...@rexursive.com>]

On Thu, 2007-05-10 at 08:20 +0200, Plüm, Rüdiger, VF-Group wrote:

> As far as I understand your problem description the bug is only in 2.2.x and not in
> trunk. So could you please give a pointer to the revision(s) in trunk that fixed this?
> This can be considered for backport then. If this is not fixed in trunk yet, please
> sent a patch that applies to trunk.

I don't think this applies to trunk. The trunk uses configuration groups
and then applies dbd_setup to all of them.

So, this is a pure bug fix for 2.2.x branch. Ditto other patch I sent to
the list today.

-- 
Bojan

Re: [PATCH]: Call dbd_setup() for all virtual hosts or create mutex inmod_dbd.c

[Bojan Smojver <bo...@rexursive.com>]

On Thu, 2007-05-10 at 17:01 +1000, Bojan Smojver wrote:

> I don't think this applies to trunk. The trunk uses configuration groups
> and then applies dbd_setup to all of them.

Looks like r503931 was where those configuration groups were introduced.
This was the text associated with the commit:

---------------------------------
Introduce configuration groups to allow inheritance by virtual hosts of
database configurations from the main server.  The post_config hook function
determines the minimal set of distinct configurations necessary so that
database connection pools are shared between virtual hosts whenever possible.

The SQL statements which should be prepared for each database connection
are now stored in a hash for each virtual host during the configuration
phase, and these hashes are merged in the normal manner using
apr_hash_overlay() with that of the main server.  This allows for statements
to be de-registered by DBDPrepareSQL, if desired.  The post_config hook
function then compares the statements registered for each virtual host
when determining if a separate configuration group is required.  The
changes in r424798, r432560, r432562, and r466641, which still have problems
with configuration inheritance, are therefore no longer necessary.
---------------------------------

-- 
Bojan