You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sidharth Mishra <si...@gmail.com> on 2021/10/28 05:08:47 UTC
Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs
-----
addons/falcon-bridge/pom.xml 9d56fd8d3
addons/hbase-bridge/pom.xml 151a62a77
addons/hive-bridge/pom.xml f62140918
addons/impala-bridge/pom.xml 87650e1da
addons/kafka-bridge/pom.xml 2ac19fd20
addons/sqoop-bridge/pom.xml 03861df84
addons/storm-bridge/pom.xml 6bfe15b5b
common/pom.xml ebf8ea5ae
graphdb/janus/pom.xml f38c4e9a3
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
pom.xml 84630e76b
repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java 2f1161067
test-tools/pom.xml 59c7a9dbf
webapp/pom.xml 443559c8d
Diff: https://reviews.apache.org/r/73669/diff/1/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
(Updated Oct. 29, 2021, 12:24 a.m.)
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs (updated)
-----
addons/falcon-bridge/pom.xml de22fa5a0
addons/hbase-bridge/pom.xml 50fb9e838
addons/hive-bridge/pom.xml ea2de4d3b
addons/impala-bridge/pom.xml a1bd5920b
addons/kafka-bridge/pom.xml 7fe97eb39
addons/sqoop-bridge/pom.xml 9d5ac52d9
addons/storm-bridge/pom.xml 71525438b
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
pom.xml 61f132320
webapp/pom.xml d90f68601
Diff: https://reviews.apache.org/r/73669/diff/6/
Changes: https://reviews.apache.org/r/73669/diff/5-6/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223692
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Oct. 28, 2021, 5:02 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 5:02 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml de22fa5a0
> addons/hbase-bridge/pom.xml 50fb9e838
> addons/hive-bridge/pom.xml ea2de4d3b
> addons/impala-bridge/pom.xml a1bd5920b
> addons/kafka-bridge/pom.xml 7fe97eb39
> addons/sqoop-bridge/pom.xml 9d5ac52d9
> addons/storm-bridge/pom.xml 71525438b
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
> pom.xml 61f132320
> webapp/pom.xml d90f68601
>
>
> Diff: https://reviews.apache.org/r/73669/diff/5/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
(Updated Oct. 29, 2021, 12:02 a.m.)
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs (updated)
-----
addons/falcon-bridge/pom.xml de22fa5a0
addons/hbase-bridge/pom.xml 50fb9e838
addons/hive-bridge/pom.xml ea2de4d3b
addons/impala-bridge/pom.xml a1bd5920b
addons/kafka-bridge/pom.xml 7fe97eb39
addons/sqoop-bridge/pom.xml 9d5ac52d9
addons/storm-bridge/pom.xml 71525438b
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
pom.xml 61f132320
webapp/pom.xml d90f68601
Diff: https://reviews.apache.org/r/73669/diff/5/
Changes: https://reviews.apache.org/r/73669/diff/4-5/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
(Updated Oct. 28, 2021, 11:02 p.m.)
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs (updated)
-----
addons/falcon-bridge/pom.xml de22fa5a0
addons/hbase-bridge/pom.xml 50fb9e838
addons/hive-bridge/pom.xml ea2de4d3b
addons/impala-bridge/pom.xml a1bd5920b
addons/kafka-bridge/pom.xml 7fe97eb39
addons/sqoop-bridge/pom.xml 9d5ac52d9
addons/storm-bridge/pom.xml 71525438b
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
pom.xml 61f132320
webapp/pom.xml d90f68601
Diff: https://reviews.apache.org/r/73669/diff/4/
Changes: https://reviews.apache.org/r/73669/diff/3-4/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
(Updated Oct. 28, 2021, 10:59 p.m.)
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs (updated)
-----
addons/falcon-bridge/pom.xml de22fa5a0
addons/hbase-bridge/pom.xml 50fb9e838
addons/hive-bridge/pom.xml ea2de4d3b
addons/impala-bridge/pom.xml a1bd5920b
addons/kafka-bridge/pom.xml 7fe97eb39
addons/sqoop-bridge/pom.xml 9d5ac52d9
addons/storm-bridge/pom.xml 71525438b
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
pom.xml 61f132320
webapp/pom.xml d90f68601
Diff: https://reviews.apache.org/r/73669/diff/3/
Changes: https://reviews.apache.org/r/73669/diff/2-3/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
> On Oct. 28, 2021, 9:55 p.m., Sarath Subramanian wrote:
> > notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
> > Lines 40 (patched)
> > <https://reviews.apache.org/r/73669/diff/2/?file=2254395#file2254395line40>
> >
> > 'reader' is never used? consider removing
Good catch. Thank you
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223687
-----------------------------------------------------------
On Oct. 28, 2021, 9:19 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 9:19 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml 9d56fd8d3
> addons/hbase-bridge/pom.xml 151a62a77
> addons/hive-bridge/pom.xml f62140918
> addons/impala-bridge/pom.xml 87650e1da
> addons/kafka-bridge/pom.xml 2ac19fd20
> addons/sqoop-bridge/pom.xml 03861df84
> addons/storm-bridge/pom.xml 6bfe15b5b
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
> pom.xml 84630e76b
> webapp/pom.xml 443559c8d
>
>
> Diff: https://reviews.apache.org/r/73669/diff/2/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223687
-----------------------------------------------------------
Fix it, then Ship it!
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 33 (patched)
<https://reviews.apache.org/r/73669/#comment312794>
+1
'attemptCount' is not a valid member when you are making this a generic method in CommandHandlerUtility
use boolean - forceKill - true/false
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 38 (patched)
<https://reviews.apache.org/r/73669/#comment312795>
getPIDOfPortUse => findProcessIdUsingPort
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 40 (patched)
<https://reviews.apache.org/r/73669/#comment312793>
'reader' is never used? consider removing
pom.xml
Line 1963 (original), 1963 (patched)
<https://reviews.apache.org/r/73669/#comment312796>
consider using variable here:
${surefire.version}
- Sarath Subramanian
On Oct. 28, 2021, 2:19 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 2:19 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml 9d56fd8d3
> addons/hbase-bridge/pom.xml 151a62a77
> addons/hive-bridge/pom.xml f62140918
> addons/impala-bridge/pom.xml 87650e1da
> addons/kafka-bridge/pom.xml 2ac19fd20
> addons/sqoop-bridge/pom.xml 03861df84
> addons/storm-bridge/pom.xml 6bfe15b5b
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
> pom.xml 84630e76b
> webapp/pom.xml 443559c8d
>
>
> Diff: https://reviews.apache.org/r/73669/diff/2/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
> On Oct. 28, 2021, 9:24 p.m., Ashutosh Mestry wrote:
> > notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
> > Lines 33 (patched)
> > <https://reviews.apache.org/r/73669/diff/2/?file=2254395#file2254395line33>
> >
> > Change attemptCount to boolean. That way you caller can simply pass true or false.
> > The logic attemptCount != 0 will depend on caller.
Good catch. Thank you
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223683
-----------------------------------------------------------
On Oct. 28, 2021, 9:19 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 9:19 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml 9d56fd8d3
> addons/hbase-bridge/pom.xml 151a62a77
> addons/hive-bridge/pom.xml f62140918
> addons/impala-bridge/pom.xml 87650e1da
> addons/kafka-bridge/pom.xml 2ac19fd20
> addons/sqoop-bridge/pom.xml 03861df84
> addons/storm-bridge/pom.xml 6bfe15b5b
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
> pom.xml 84630e76b
> webapp/pom.xml 443559c8d
>
>
> Diff: https://reviews.apache.org/r/73669/diff/2/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223683
-----------------------------------------------------------
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java
Lines 123 (patched)
<https://reviews.apache.org/r/73669/#comment312791>
nit: Fix formatting.
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 33 (patched)
<https://reviews.apache.org/r/73669/#comment312787>
Change attemptCount to boolean. That way you caller can simply pass true or false.
The logic attemptCount != 0 will depend on caller.
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 42 (patched)
<https://reviews.apache.org/r/73669/#comment312788>
Refactor promote to private static final field.
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 74 (patched)
<https://reviews.apache.org/r/73669/#comment312789>
Change StringUtils.isBlank to StringUtils.isEmpty.
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java
Lines 78 (patched)
<https://reviews.apache.org/r/73669/#comment312790>
Refactor: Promote to private static final String.
- Ashutosh Mestry
On Oct. 28, 2021, 9:19 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 9:19 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml 9d56fd8d3
> addons/hbase-bridge/pom.xml 151a62a77
> addons/hive-bridge/pom.xml f62140918
> addons/impala-bridge/pom.xml 87650e1da
> addons/kafka-bridge/pom.xml 2ac19fd20
> addons/sqoop-bridge/pom.xml 03861df84
> addons/storm-bridge/pom.xml 6bfe15b5b
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
> pom.xml 84630e76b
> webapp/pom.xml 443559c8d
>
>
> Diff: https://reviews.apache.org/r/73669/diff/2/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
(Updated Oct. 28, 2021, 9:19 p.m.)
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs
-----
addons/falcon-bridge/pom.xml 9d56fd8d3
addons/hbase-bridge/pom.xml 151a62a77
addons/hive-bridge/pom.xml f62140918
addons/impala-bridge/pom.xml 87650e1da
addons/kafka-bridge/pom.xml 2ac19fd20
addons/sqoop-bridge/pom.xml 03861df84
addons/storm-bridge/pom.xml 6bfe15b5b
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
pom.xml 84630e76b
webapp/pom.xml 443559c8d
Diff: https://reviews.apache.org/r/73669/diff/2/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/
-----------------------------------------------------------
(Updated Oct. 28, 2021, 9:11 p.m.)
Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4462
https://issues.apache.org/jira/browse/ATLAS-4462
Repository: atlas
Description
-------
ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
Diffs (updated)
-----
addons/falcon-bridge/pom.xml 9d56fd8d3
addons/hbase-bridge/pom.xml 151a62a77
addons/hive-bridge/pom.xml f62140918
addons/impala-bridge/pom.xml 87650e1da
addons/kafka-bridge/pom.xml 2ac19fd20
addons/sqoop-bridge/pom.xml 03861df84
addons/storm-bridge/pom.xml 6bfe15b5b
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java PRE-CREATION
pom.xml 84630e76b
webapp/pom.xml 443559c8d
Diff: https://reviews.apache.org/r/73669/diff/2/
Changes: https://reviews.apache.org/r/73669/diff/1-2/
Testing
-------
Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
Thanks,
Sidharth Mishra
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Sidharth Mishra <si...@gmail.com>.
> On Oct. 28, 2021, 6:08 a.m., Ashutosh Mestry wrote:
> > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/73669/diff/1/?file=2254372#file2254372line187>
> >
> > Instead of killing the process, why not attempt to use next available port.
I tried using different ports but as other places and clients are using a single config file which would have been loaded with the initial default port we can't really achieve this without major changes So implemented the kill option.
> On Oct. 28, 2021, 6:08 a.m., Ashutosh Mestry wrote:
> > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java
> > Lines 194 (patched)
> > <https://reviews.apache.org/r/73669/diff/1/?file=2254372#file2254372line197>
> >
> > This won't work on Windows.
Even the command fails at windows it will not have any impact or retry logic as other platforms. So if these command succeed then only we will retry with terminating the process which uses the port.
> On Oct. 28, 2021, 6:08 a.m., Ashutosh Mestry wrote:
> > pom.xml
> > Line 1688 (original), 1680 (patched)
> > <https://reviews.apache.org/r/73669/diff/1/?file=2254373#file2254373line1688>
> >
> > What is the reason for downgrading this?
This was part of reverting the ATLAS-4351 changes.
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223679
-----------------------------------------------------------
On Oct. 28, 2021, 5:08 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 5:08 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml 9d56fd8d3
> addons/hbase-bridge/pom.xml 151a62a77
> addons/hive-bridge/pom.xml f62140918
> addons/impala-bridge/pom.xml 87650e1da
> addons/kafka-bridge/pom.xml 2ac19fd20
> addons/sqoop-bridge/pom.xml 03861df84
> addons/storm-bridge/pom.xml 6bfe15b5b
> common/pom.xml ebf8ea5ae
> graphdb/janus/pom.xml f38c4e9a3
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> pom.xml 84630e76b
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java 2f1161067
> test-tools/pom.xml 59c7a9dbf
> webapp/pom.xml 443559c8d
>
>
> Diff: https://reviews.apache.org/r/73669/diff/1/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and
PreCommit tests are also failing
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73669/#review223679
-----------------------------------------------------------
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java
Lines 184 (patched)
<https://reviews.apache.org/r/73669/#comment312780>
Instead of killing the process, why not attempt to use next available port.
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java
Lines 194 (patched)
<https://reviews.apache.org/r/73669/#comment312779>
This won't work on Windows.
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java
Lines 207 (patched)
<https://reviews.apache.org/r/73669/#comment312781>
Call this in finally
pom.xml
Line 1688 (original), 1680 (patched)
<https://reviews.apache.org/r/73669/#comment312778>
What is the reason for downgrading this?
repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
Line 70 (original), 72 (patched)
<https://reviews.apache.org/r/73669/#comment312782>
If possible, package this in a separate patch.
repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
Lines 185 (patched)
<https://reviews.apache.org/r/73669/#comment312776>
Change: Index Health Monitor: Shutdown: Starting...
repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java
Lines 195 (patched)
<https://reviews.apache.org/r/73669/#comment312777>
Change: Index Health Monitor: Shutdown: Done! Add this to finally block.
- Ashutosh Mestry
On Oct. 28, 2021, 5:08 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73669/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2021, 5:08 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4462
> https://issues.apache.org/jira/browse/ATLAS-4462
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to true to stop jetty at end of post integration, Added retry logic for Kafka start having port bind issue, Fixed Infinite loop for Index Recovery Service
>
>
> Diffs
> -----
>
> addons/falcon-bridge/pom.xml 9d56fd8d3
> addons/hbase-bridge/pom.xml 151a62a77
> addons/hive-bridge/pom.xml f62140918
> addons/impala-bridge/pom.xml 87650e1da
> addons/kafka-bridge/pom.xml 2ac19fd20
> addons/sqoop-bridge/pom.xml 03861df84
> addons/storm-bridge/pom.xml 6bfe15b5b
> common/pom.xml ebf8ea5ae
> graphdb/janus/pom.xml f38c4e9a3
> notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java 19717fb2b
> pom.xml 84630e76b
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java 2f1161067
> test-tools/pom.xml 59c7a9dbf
> webapp/pom.xml 443559c8d
>
>
> Diff: https://reviews.apache.org/r/73669/diff/1/
>
>
> Testing
> -------
>
> Manually tested the Infinite loop issue at Index Recovery Service, Kafka retry logic for kafka start. Along with this I ran the local tests which passed.
>
>
> Thanks,
>
> Sidharth Mishra
>
>