You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gu...@apache.org on 2017/10/17 08:25:35 UTC

[22/50] incubator-weex git commit: * [test] bugfix for unexpected error

* [test] bugfix for unexpected error


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/e904b629
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/e904b629
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/e904b629

Branch: refs/heads/release-0.16
Commit: e904b629932ee5fd833dc93c17f7f1dadff38e5a
Parents: 34b7b1b
Author: gurisxie <27...@qq.com>
Authored: Tue Oct 10 10:13:59 2017 +0800
Committer: gurisxie <27...@qq.com>
Committed: Tue Oct 10 12:11:25 2017 +0800

----------------------------------------------------------------------
 dangerfile.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/e904b629/dangerfile.js
----------------------------------------------------------------------
diff --git a/dangerfile.js b/dangerfile.js
index 248276a..97c4146 100644
--- a/dangerfile.js
+++ b/dangerfile.js
@@ -418,7 +418,7 @@ function findBlameReviewers(fileToDeletedLinesMap, fileToNormalLinesMap, fileToB
     }
     deletedLines.forEach(lineNumber => {
       var name = blames[lineNumber]
-      if (!!reviewers) {
+      if (name && !!reviewers) {
         reviewers[name] = (reviewers[name] || 0) + 3
       }
     })
@@ -433,7 +433,7 @@ function findBlameReviewers(fileToDeletedLinesMap, fileToNormalLinesMap, fileToB
     }
     normalLines.forEach(lineNumber => {
       var name = blames[lineNumber]
-      if (!!reviewers) {
+      if (name && !!reviewers) {
         reviewers[name] = (reviewers[name] || 0) + 1
       }
     })