You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/09 04:31:32 UTC

[GitHub] [iotdb] stormbroken commented on a change in pull request #4527: [IOTDB-1968] Mount the Metric Service as a Built-in IService

stormbroken commented on a change in pull request #4527:
URL: https://github.com/apache/iotdb/pull/4527#discussion_r765425195



##########
File path: metrics/micrometer-metrics/src/main/java/org/apache/iotdb/metrics/micrometer/reporter/MicrometerPrometheusReporter.java
##########
@@ -65,11 +65,10 @@ public boolean start() {
             .route(

Review comment:
       ok, it's a good idea. I think we could finish this in another PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org