You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by adufilie <gi...@git.apache.org> on 2015/12/01 19:06:30 UTC
[GitHub] flex-asjs pull request: Language.js bug fixes and improvements
GitHub user adufilie opened a pull request:
https://github.com/apache/flex-asjs/pull/3
Language.js bug fixes and improvements
Individual improvements are separated into different commits.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adufilie/flex-asjs develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-asjs/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit d30d7ee456eab2e2cf1ac9205023387f6919c42d
Author: Andy Dufilie <an...@iweave.com>
Date: 2015-12-01T17:11:34Z
fixed some typos in Language.js
commit 45e112f087cceb02e656cf22822ea04aa8271a54
Author: Andy Dufilie <an...@iweave.com>
Date: 2015-12-01T17:14:20Z
It's more useful if we pass trace() args directly to console.log() instead of converting them to strings first
commit 4d1ec90f618c4ed8addc39083a4d00416f33e0a8
Author: Andy Dufilie <an...@iweave.com>
Date: 2015-12-01T17:29:59Z
is() code is now more robust and works with Boolean
commit 952f12ba2ed6f98258cdb90cb93e2be657be5ec4
Author: Andy Dufilie <an...@iweave.com>
Date: 2015-12-01T17:37:49Z
avoid creating new instance of interface by checking prototype
commit 321b367a7b64d521bc339b85f3a65edd1d4806d9
Author: Andy Dufilie <an...@iweave.com>
Date: 2015-12-01T17:47:25Z
Moved checkInterfaces to a separate function to avoid recreating it each time
commit 72878086671b9f1833847ee7f3e847ecfe34e6cc
Author: Andy Dufilie <an...@iweave.com>
Date: 2015-12-01T18:01:07Z
Added implementations for "classDef is Class" and "classDef as Class"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] flex-asjs pull request: Language.js bug fixes and improvements
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Alex,
It doesnt seem like your response got posted to the git pull conversation
here: https://github.com/apache/flex-asjs/pull/3
You might want to reply to the contributor directly on that page.
Thanks,
Om
On Tue, Dec 1, 2015 at 11:09 PM, Alex Harui <ah...@adobe.com> wrote:
> Hi,
>
> Thanks for these improvements. It turns out we are refactoring
> Language.js in the core_js_to_as branch right now. I will fold your
> changes in after we merge the refactoring back into the develop branch.
>
> -Alex
>
> On 12/1/15, 10:06 AM, "adufilie" <gi...@git.apache.org> wrote:
>
> >GitHub user adufilie opened a pull request:
> >
> > https://github.com/apache/flex-asjs/pull/3
> >
> > Language.js bug fixes and improvements
> >
> > Individual improvements are separated into different commits.
> >
> >You can merge this pull request into a Git repository by running:
> >
> > $ git pull https://github.com/adufilie/flex-asjs develop
> >
> >Alternatively you can review and apply these changes as the patch at:
> >
> > https://github.com/apache/flex-asjs/pull/3.patch
> >
> >To close this pull request, make a commit to your master/trunk branch
> >with (at least) the following in the commit message:
> >
> > This closes #3
> >
> >----
> >commit d30d7ee456eab2e2cf1ac9205023387f6919c42d
> >Author: Andy Dufilie <an...@iweave.com>
> >Date: 2015-12-01T17:11:34Z
> >
> > fixed some typos in Language.js
> >
> >commit 45e112f087cceb02e656cf22822ea04aa8271a54
> >Author: Andy Dufilie <an...@iweave.com>
> >Date: 2015-12-01T17:14:20Z
> >
> > It's more useful if we pass trace() args directly to console.log()
> >instead of converting them to strings first
> >
> >commit 4d1ec90f618c4ed8addc39083a4d00416f33e0a8
> >Author: Andy Dufilie <an...@iweave.com>
> >Date: 2015-12-01T17:29:59Z
> >
> > is() code is now more robust and works with Boolean
> >
> >commit 952f12ba2ed6f98258cdb90cb93e2be657be5ec4
> >Author: Andy Dufilie <an...@iweave.com>
> >Date: 2015-12-01T17:37:49Z
> >
> > avoid creating new instance of interface by checking prototype
> >
> >commit 321b367a7b64d521bc339b85f3a65edd1d4806d9
> >Author: Andy Dufilie <an...@iweave.com>
> >Date: 2015-12-01T17:47:25Z
> >
> > Moved checkInterfaces to a separate function to avoid recreating it
> >each time
> >
> >commit 72878086671b9f1833847ee7f3e847ecfe34e6cc
> >Author: Andy Dufilie <an...@iweave.com>
> >Date: 2015-12-01T18:01:07Z
> >
> > Added implementations for "classDef is Class" and "classDef as Class"
> >
> >----
> >
> >
> >---
> >If your project is set up for it, you can reply to this email and have
> >your
> >reply appear on GitHub as well. If your project does not have this feature
> >enabled and wishes so, or if the feature is enabled but not working,
> >please
> >contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> >with INFRA.
> >---
>
>
Re: [GitHub] flex-asjs pull request: Language.js bug fixes and
improvements
Posted by Alex Harui <ah...@adobe.com>.
Hi,
Thanks for these improvements. It turns out we are refactoring
Language.js in the core_js_to_as branch right now. I will fold your
changes in after we merge the refactoring back into the develop branch.
-Alex
On 12/1/15, 10:06 AM, "adufilie" <gi...@git.apache.org> wrote:
>GitHub user adufilie opened a pull request:
>
> https://github.com/apache/flex-asjs/pull/3
>
> Language.js bug fixes and improvements
>
> Individual improvements are separated into different commits.
>
>You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/adufilie/flex-asjs develop
>
>Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/flex-asjs/pull/3.patch
>
>To close this pull request, make a commit to your master/trunk branch
>with (at least) the following in the commit message:
>
> This closes #3
>
>----
>commit d30d7ee456eab2e2cf1ac9205023387f6919c42d
>Author: Andy Dufilie <an...@iweave.com>
>Date: 2015-12-01T17:11:34Z
>
> fixed some typos in Language.js
>
>commit 45e112f087cceb02e656cf22822ea04aa8271a54
>Author: Andy Dufilie <an...@iweave.com>
>Date: 2015-12-01T17:14:20Z
>
> It's more useful if we pass trace() args directly to console.log()
>instead of converting them to strings first
>
>commit 4d1ec90f618c4ed8addc39083a4d00416f33e0a8
>Author: Andy Dufilie <an...@iweave.com>
>Date: 2015-12-01T17:29:59Z
>
> is() code is now more robust and works with Boolean
>
>commit 952f12ba2ed6f98258cdb90cb93e2be657be5ec4
>Author: Andy Dufilie <an...@iweave.com>
>Date: 2015-12-01T17:37:49Z
>
> avoid creating new instance of interface by checking prototype
>
>commit 321b367a7b64d521bc339b85f3a65edd1d4806d9
>Author: Andy Dufilie <an...@iweave.com>
>Date: 2015-12-01T17:47:25Z
>
> Moved checkInterfaces to a separate function to avoid recreating it
>each time
>
>commit 72878086671b9f1833847ee7f3e847ecfe34e6cc
>Author: Andy Dufilie <an...@iweave.com>
>Date: 2015-12-01T18:01:07Z
>
> Added implementations for "classDef is Class" and "classDef as Class"
>
>----
>
>
>---
>If your project is set up for it, you can reply to this email and have
>your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working,
>please
>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>with INFRA.
>---
[GitHub] flex-asjs pull request: Language.js bug fixes and improvements
Posted by aharui <gi...@git.apache.org>.
Github user aharui commented on the pull request:
https://github.com/apache/flex-asjs/pull/3#issuecomment-161399542
Hi,
Thanks for these improvements. It turns out we are refactoring
Language.js in the core_js_to_as branch right now. I will fold your
changes in after we merge the refactoring back into the develop branch.
-Alex
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flex-asjs pull request: Language.js bug fixes and improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flex-asjs/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---