You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/07 15:42:26 UTC

[GitHub] [trafficcontrol] rob05c opened a new issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

rob05c opened a new issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940


   IP+Port makes much more sense for the Unique Key. The IP+Port is what uniquely defines the server for requests (At the HTTP level, arguably FQDN+Port, but the current key is IP, which is the unique identifier at the IP level).
   
   The current IP,Profile setting is undesirable because it makes creating multiple similar servers a huge pain, having to create many duplicate profiles. It also allows for duplicate IP+Port, which should not be allowed. TC should be standardized around either IP+Port or FQDN+Port (possibly both).
   
   Labeling 'enhancement' - but this is a on the line of bug, enhancement, and tech debt.
   
   ## I'm submitting a ...
   -  improvement request (usability, performance, tech debt, etc.)
   
   ## Traffic Control components affected ...
   -  Traffic Ops
   
   ## Current behavior:
   TO Server Unique key is IP+Profile
   
   ## Expected / new behavior:
   TO Server Unique key should be IP+Port. Consider also adding a Domain+Hostname+Port Unique Key.
   
   ## Minimal reproduction of the problem with instructions:
   Try to make 2 servers with the same IP and Profile and different Ports. Observe error.
   
   ## Anything else:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a edited a comment on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
jhg03a edited a comment on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-673146423


   The main feature gain Origins has that servers doesn't is the ability to assign a geo-coordinate to an individual origin instead of an origin cachegroup like in the past.  This is mainly used for geo-routed client steering.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-672985353


   This is a problem for MSO VIP.  We can make additional MSO server profiles to satisfy the unique constraint.  We can't force load balancers to use multiple ports.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-967258957


   No, with interfaces, the IP the issue refers to is now the "service IP address(es)" of the cache server. It's become a much more complex key, but not less reasonable, really.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-673146141


   Servers came first and origins is backward compatible with it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-673146423


   The main feature gain Origins has that servers doesn't is the ability to assign a geo-coordinate to an individual origin instead of an origin cachegroup like in the past.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-967282258


   > No, with interfaces, the IP the issue refers to is now the "service IP address(es)" of the cache server. It's become a much more complex key, but not less reasonable, really.
   
   ^^ it sounds like that answer is a "yes, problem still exists". is that true?
   
   so can i do this currently?
   
   server 1: profile A, IP address=1.1.1.1, port=80
   server 2: profile A, IP address=1.1.1.1, port=8080


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] mitchell852 commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-967255036


   is this still relevant? did any of this change with the introduction of server interfaces?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-672987521


   Somebody needs to refresh me on why MSO uses servers instead of Origins.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-967295390


   Yeah, the constraint is still profile and IP afaik


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-673155316


   I feel like there was a reason we couldn't switch to Origins yet, though, and idk if/where that discussion was captured.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] bdgranger commented on issue #4940: Change Traffic Ops Server Unique Key from IP,Profile to IP,Port

Posted by GitBox <gi...@apache.org>.
bdgranger commented on issue #4940:
URL: https://github.com/apache/trafficcontrol/issues/4940#issuecomment-967284174


   I haven't tried it recently, but I think that the uniqueness constraint
   will still flag this as not allowed because the profile is the same?
   
   
   On Fri, Nov 12, 2021 at 12:18 PM Jeremy Mitchell ***@***.***>
   wrote:
   
   > No, with interfaces, the IP the issue refers to is now the "service IP
   > address(es)" of the cache server. It's become a much more complex key, but
   > not less reasonable, really.
   >
   > ^^ it sounds like that answer is a "yes, problem still exists". is that
   > true?
   >
   > so can i do this currently?
   >
   > server 1: profile A, IP address=1.1.1.1, port=80
   > server 2: profile A, IP address=1.1.1.1, port=8080
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/trafficcontrol/issues/4940#issuecomment-967282258>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AQKEYATCPW2IYOUDAGQISXLULVD5TANCNFSM4PXX6SNQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org