You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/09 18:15:13 UTC
[GitHub] [trafficcontrol] ARMmaster17 opened a new pull request #5131: Added User-Agent String to Traffic Router Log Output
ARMmaster17 opened a new pull request #5131:
URL: https://github.com/apache/trafficcontrol/pull/5131
## What does this PR (Pull Request) do?
Requested by @smalenfant, adds User-Agent header string to log output from Traffic Router for each request.
- [x] This PR is not related to any Issue
## Which Traffic Control components are affected by this PR?
- Traffic Router
## What is the best way to verify this PR?
Pull and run CDN-in-a-Box and make a request against traffic router using the built-in VNC container (or your own custom solution). Check the console output of Traffic Router from the request and verify the that a field exists similar to `uas="Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0"`.
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #5131: Added User-Agent String to Traffic Router Log Output
Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #5131:
URL: https://github.com/apache/trafficcontrol/pull/5131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5131: Added User-Agent String to Traffic Router Log Output
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5131:
URL: https://github.com/apache/trafficcontrol/pull/5131#discussion_r505505706
##########
File path: CHANGELOG.md
##########
@@ -56,7 +56,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added Traffic Monitor: Support stats over http CSV output. Officially supported in ATS 9.0 unless backported by users. Users must also include `system_stats.so` when using stats over http in order to keep all the same functionality (and included stats) that astats_over_http provides.
- Added ability for Traffic Monitor to determine health of cache based on interface data and aggregate data. Using the new `stats_over_http` `health.polling.format` value that allows monitoring of multiple interfaces will first require that *all* Traffic Monitors monitoring the affected cache server be upgraded.
- Traffic Ops, Traffic Ops ORT, Traffic Monitor, Traffic Stats, and Grove are now compiled using Go version 1.15.
-- Added `--traffic_ops_insecure=<0|1>` optional option to traffic_ops_ort.pl
Review comment:
We still want this changelog message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ARMmaster17 commented on a change in pull request #5131: Added User-Agent String to Traffic Router Log Output
Posted by GitBox <gi...@apache.org>.
ARMmaster17 commented on a change in pull request #5131:
URL: https://github.com/apache/trafficcontrol/pull/5131#discussion_r505539788
##########
File path: CHANGELOG.md
##########
@@ -56,7 +56,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Added Traffic Monitor: Support stats over http CSV output. Officially supported in ATS 9.0 unless backported by users. Users must also include `system_stats.so` when using stats over http in order to keep all the same functionality (and included stats) that astats_over_http provides.
- Added ability for Traffic Monitor to determine health of cache based on interface data and aggregate data. Using the new `stats_over_http` `health.polling.format` value that allows monitoring of multiple interfaces will first require that *all* Traffic Monitors monitoring the affected cache server be upgraded.
- Traffic Ops, Traffic Ops ORT, Traffic Monitor, Traffic Stats, and Grove are now compiled using Go version 1.15.
-- Added `--traffic_ops_insecure=<0|1>` optional option to traffic_ops_ort.pl
Review comment:
Oops! Should be fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org