You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2017/05/10 19:57:33 UTC
svn commit: r1794753 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Author: lehmi
Date: Wed May 10 19:57:33 2017
New Revision: 1794753
URL: http://svn.apache.org/viewvc?rev=1794753&view=rev
Log:
PDFBOX-3788: optimized debug message
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java?rev=1794753&r1=1794752&r2=1794753&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Wed May 10 19:57:33 2017
@@ -1255,26 +1255,25 @@ public class COSParser extends BaseParse
private boolean validateXrefOffsets(Map<COSObjectKey, Long> xrefOffset) throws IOException
{
- boolean valid = true;
- if (xrefOffset != null)
+ if (xrefOffset == null)
{
- for (Entry<COSObjectKey, Long> objectEntry : xrefOffset.entrySet())
+ return true;
+ }
+ for (Entry<COSObjectKey, Long> objectEntry : xrefOffset.entrySet())
+ {
+ COSObjectKey objectKey = objectEntry.getKey();
+ Long objectOffset = objectEntry.getValue();
+ // a negative offset number represents a object number itself
+ // see type 2 entry in xref stream
+ if (objectOffset != null && objectOffset >= 0
+ && !checkObjectKeys(objectKey, objectOffset))
{
- COSObjectKey objectKey = objectEntry.getKey();
- Long objectOffset = objectEntry.getValue();
- // a negative offset number represents a object number itself
- // see type 2 entry in xref stream
- if (objectOffset != null && objectOffset >= 0
- && !checkObjectKeys(objectKey, objectOffset))
- {
- LOG.debug(
- "Stop checking xref offsets as at least one couldn't be dereferenced");
- valid = false;
- break;
- }
+ LOG.debug("Stop checking xref offsets as at least one (" + objectKey
+ + ") couldn't be dereferenced");
+ return false;
}
}
- return valid;
+ return true;
}
/**