You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Newton Alex <na...@pivotal.io> on 2015/12/29 23:40:03 UTC
Review Request 41784: NN HA wizard should update hawq_dfs_url with
nameservice when ha is enabled by ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41784/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, and Jaimin Jetly.
Bugs: AMBARI-14225
https://issues.apache.org/jira/browse/AMBARI-14225
Repository: ambari
Description
-------
There were some minor changes to the patch to make it work for branch-2.2 as compared to trunk. Hence re-creating a new review request.
Diffs
-----
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e86b52e
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 3cb7be7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 580977a
ambari-web/app/data/HDP2/ha_properties.js 627018a
ambari-web/app/messages.js f52b325
Diff: https://reviews.apache.org/r/41784/diff/
Testing
-------
Yes, unit tests passed.
Manually tested the feature.
Thanks,
Newton Alex
Re: Review Request 41784: NN HA wizard should update hawq_dfs_url with
nameservice when ha is enabled by ambari
Posted by Newton Alex <na...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41784/
-----------------------------------------------------------
(Updated Dec. 31, 2015, 1:09 a.m.)
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, and Jaimin Jetly.
Bugs: AMBARI-14225
https://issues.apache.org/jira/browse/AMBARI-14225
Repository: ambari
Description
-------
There were some minor changes to the patch to make it work for branch-2.2 as compared to trunk. Hence re-creating a new review request.
Diffs
-----
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e86b52e
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 3cb7be7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 580977a
ambari-web/app/data/HDP2/ha_properties.js 627018a
ambari-web/app/messages.js 820d3c9
Diff: https://reviews.apache.org/r/41784/diff/
Testing (updated)
-------
Yes, unit tests passed.
Manually tested the feature.
-----
Configuration test is randomized
TRACE: Entering db:getUser function
Trace: Entering db:getLoginName function
TRACE: Entering db:setUser function
TRACE: Entering db:setLoginName function
field0 IS INVALID : This is required
FORM FIELD VALUE: true
displayName = HDFS
displayName = YARN
new_password IS INVALID : This is required
password IS INVALID : This is required
passwordRetype IS INVALID : This is required
10291 tests complete (28 seconds)
121 tests pending
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1242 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1242 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2:18.667s
[INFO] Finished at: Wed Dec 30 17:08:01 PST 2015
[INFO] Final Memory: 6M/81M
[INFO] ------------------------------------------------------------------------
nalex@office-4-248:~/Git/pivotal/ambari/ambari-web#
-----
Thanks,
Newton Alex
Re: Review Request 41784: NN HA wizard should update hawq_dfs_url with
nameservice when ha is enabled by ambari
Posted by Newton Alex <na...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41784/
-----------------------------------------------------------
(Updated Dec. 30, 2015, 10:54 p.m.)
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, and Jaimin Jetly.
Changes
-------
Incorporated code review comments
Bugs: AMBARI-14225
https://issues.apache.org/jira/browse/AMBARI-14225
Repository: ambari
Description
-------
There were some minor changes to the patch to make it work for branch-2.2 as compared to trunk. Hence re-creating a new review request.
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e86b52e
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 3cb7be7
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 580977a
ambari-web/app/data/HDP2/ha_properties.js 627018a
ambari-web/app/messages.js 820d3c9
Diff: https://reviews.apache.org/r/41784/diff/
Testing
-------
Yes, unit tests passed.
Manually tested the feature.
Thanks,
Newton Alex
Re: Review Request 41784: NN HA wizard should update hawq_dfs_url with
nameservice when ha is enabled by ambari
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41784/#review112242
-----------------------------------------------------------
ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js (line 37)
<https://reviews.apache.org/r/41784/#comment172598>
Have you added a corresponding title in messages.js for this step in the rollback controller?
- Matt
On Dec. 29, 2015, 2:40 p.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41784/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 2:40 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, and Jaimin Jetly.
>
>
> Bugs: AMBARI-14225
> https://issues.apache.org/jira/browse/AMBARI-14225
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There were some minor changes to the patch to make it work for branch-2.2 as compared to trunk. Hence re-creating a new review request.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js e86b52e
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js 3cb7be7
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js 580977a
> ambari-web/app/data/HDP2/ha_properties.js 627018a
> ambari-web/app/messages.js f52b325
>
> Diff: https://reviews.apache.org/r/41784/diff/
>
>
> Testing
> -------
>
> Yes, unit tests passed.
> Manually tested the feature.
>
>
> Thanks,
>
> Newton Alex
>
>