You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metamodel.apache.org by "Julien Foltz (JIRA)" <ji...@apache.org> on 2018/10/29 15:34:11 UTC
[jira] [Created] (METAMODEL-1201) Remove guava dependency in
package jdbc
Julien Foltz created METAMODEL-1201:
---------------------------------------
Summary: Remove guava dependency in package jdbc
Key: METAMODEL-1201
URL: https://issues.apache.org/jira/browse/METAMODEL-1201
Project: Apache MetaModel
Issue Type: Task
Affects Versions: 5.0.0, 5.1.0
Reporter: Julien Foltz
guava dependency is only used in one class (org.apache.metamodel.jdbc.dialects.HsqldbQueryRewriter)
{{@Override}}
{{public boolean needsQuoting(String alias, String identifierQuoteString) }}{{{}}
{{ boolean containsLowerCase = CharMatcher.JAVA_LOWER_CASE.matchesAnyOf(identifierQuoteString);}}
{{ return containsLowerCase || super.needsQuoting(alias, identifierQuoteString);}}
{{}}}
It could be rewritten this way, to get rid of the dependency :
{{@Override}}
{{public boolean needsQuoting(String alias, String identifierQuoteString) }}{{{}}
{{ if (alias != null)}}
{{ for (int i = 0; i < alias.length(); i++)}}
{{ if (Character.isLowerCase(alias.charAt(i)))}}
{{ return true;}}
{{ return super.needsQuoting(alias, identifierQuoteString);}}
{{}}}
Note: DefaultQueryRewriter.needsQuoting is protected, not public
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)