You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:59:14 UTC
Review Request 61351: Removed `GroupSource.cmake`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61351/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
While we want to group sources, this current isn't working as intended,
and we will come back and set it up once the refactor is complete.
Diffs
-----
3rdparty/stout/cmake/GroupSource.cmake 7ed0b1981a70f5ab46f093a1cde86c922f1115ed
Diff: https://reviews.apache.org/r/61351/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61351: Removed `GroupSource.cmake`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61351/#review184440
-----------------------------------------------------------
Bad patch!
Reviews applied: [61351, 61350, 61287]
Failed command: python support/apply-reviews.py -n -r 61287
Error:
2017-09-02 18:54:50 URL:https://reviews.apache.org/r/61287/diff/raw/ [1797/1797] -> "61287.patch" [1]
error: patch failed: 3rdparty/stout/cmake/StoutConfigure.cmake:27
error: 3rdparty/stout/cmake/StoutConfigure.cmake: patch does not apply
error: patch failed: 3rdparty/stout/tests/CMakeLists.txt:108
error: 3rdparty/stout/tests/CMakeLists.txt: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19172/console
- Mesos Reviewbot
On Aug. 2, 2017, 12:59 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61351/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2017, 12:59 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-6721
> https://issues.apache.org/jira/browse/MESOS-6721
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While we want to group sources, this current isn't working as intended,
> and we will come back and set it up once the refactor is complete.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/GroupSource.cmake 7ed0b1981a70f5ab46f093a1cde86c922f1115ed
>
>
> Diff: https://reviews.apache.org/r/61351/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61351: Removed `GroupSource.cmake`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61351/#review184433
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 1, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61351/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:59 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While we want to group sources, this current isn't working as intended,
> and we will come back and set it up once the refactor is complete.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/GroupSource.cmake 7ed0b1981a70f5ab46f093a1cde86c922f1115ed
>
>
> Diff: https://reviews.apache.org/r/61351/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>