You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/18 01:59:00 UTC
[GitHub] [hbase] bharathv commented on a change in pull request #1064:
HBASE-23707 Add IntelliJ check style plugin configuration
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
URL: https://github.com/apache/hbase/pull/1064#discussion_r368198213
##########
File path: .idea/checkstyle-idea.xml
##########
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+ <component name="CheckStyle-IDEA">
+ <option name="configuration">
+ <map>
+ <entry key="checkstyle-version" value="8.28" />
Review comment:
Shouldn't we include the path for active configuration? Something like below, otherwise how does it hook up with our check style plugin? Something like below..
```
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="CheckStyle-IDEA">
<option name="configuration">
<map>
<entry key="active-configuration" value="LOCAL_FILE:$PROJECT_DIR$/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml:hbase" />
<entry key="checkstyle-version" value="8.10.1" />
<entry key="copy-libs" value="false" />
<entry key="location-0" value="BUNDLED:(bundled):Sun Checks" />
<entry key="location-1" value="BUNDLED:(bundled):Google Checks" />
<entry key="location-2" value="LOCAL_FILE:$PROJECT_DIR$/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml:hbase" />
<entry key="scan-before-checkin" value="false" />
<entry key="scanscope" value="JavaOnlyWithTests" />
<entry key="suppress-errors" value="false" />
</map>
</option>
</component>
</project>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services