You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by gu...@apache.org on 2021/09/17 06:24:05 UTC
[dubbo-samples] branch master updated: fix: prevent the test being
ignored
This is an automated email from the ASF dual-hosted git repository.
guohao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 6c814d2 fix: prevent the test being ignored
new ec3077e Merge pull request #369 from guohao/specify-migration-consuemr-verison
6c814d2 is described below
commit 6c814d2f850ce991b89292ebc5f8adc4e33da48b
Author: plusmancn <pl...@gmail.com>
AuthorDate: Fri Sep 17 14:00:24 2021 +0800
fix: prevent the test being ignored
---
dubbo-samples-migration/README.md | 12 ++++++++----
.../dubbo-samples-migration-case-default/case-versions.conf | 2 +-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/dubbo-samples-migration/README.md b/dubbo-samples-migration/README.md
index ed95960..7feebb4 100644
--- a/dubbo-samples-migration/README.md
+++ b/dubbo-samples-migration/README.md
@@ -15,20 +15,24 @@ dubbo.consumer.version=2.7.*
```
And then in each consumer and provider project, you can configure `POM`'s properties as follows:
```xml
-# consumer side
+<!-- consumer side -->
<properties>
<dubbo.consumer.version>2.7.13</dubbo.consumer.version>
</properties>
-# provider side
+<!-- provider side -->
<properties>
<dubbo.provider.version>2.7.13</dubbo.provider.version>
</properties>
```
-When the Integration Tests trigger, these properties will be overwritten by maven, for example:
+If we have the env of `DUBBO_VERSION=3.0.3-SNAPSHOT,2.7.13`, when the Integration Tests trigger, these properties will be overwritten by maven, for example:
```shell
mvn -Ddubbo.provider.version=3.0.3-SNAPSHOT -Ddubbo.consumer.version=2.7.13 -Dspring.version=4.3.16.RELEASE
```
-
+But in the dubbo-samples's Dubbo 3 CI env, there only has `DUBBO_VERSION=3.0.3-SNAPSHOT`, we have to specify one side's version to prevent the test being ignored, for example:
+```yaml
+dubbo.provider.version=3.*
+dubbo.consumer.version=2.7.13 # <= specific version
+```
\ No newline at end of file
diff --git a/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf b/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf
index 3e63442..b5a235b 100644
--- a/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf
+++ b/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf
@@ -23,4 +23,4 @@ spring.version=4.*, 5.*
# Support Compatibility test
dubbo.provider.version=3.*
-dubbo.consumer.version=2.7.*
+dubbo.consumer.version=2.7.13
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org