[2/2] brooklyn-server git commit: Closes #425

[sv...@apache.org]

Closes #425

Factor security group code out into separate utility class

Factor out the functionality for security groups.

Brings the create/delete and add/remove permissions functionality
for security groups from JcloudsLocationSecurityGroupCustomizer
out into its own class. The aim is to make it more convenient
to write other customizers etc. that might need security groups.

This is intended as nearly as possible as a behaviour-preserving
change. I have permitted myself one change to the behaviour where
this seemed sensible; the loop in `runOperationWithRetry`
was effectively an infinite loop because of its 100 iteration
exponential back-off, so I have changed this to a back-off that
tries for about five minutes.


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/95cf0f9a
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/95cf0f9a
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/95cf0f9a

Branch: refs/heads/master
Commit: 95cf0f9a60934bf7c0c25069f52480699aa2d4aa
Parents: 836cc2b a27656c
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Wed Nov 23 14:17:06 2016 +0200
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Wed Nov 23 14:17:06 2016 +0200

----------------------------------------------------------------------
 .../JcloudsLocationSecurityGroupCustomizer.java | 260 +++++++----------
 .../jclouds/networking/SecurityGroupEditor.java | 284 +++++++++++++++++++
 .../SharedLocationSecurityGroupCustomizer.java  |   2 +-
 ...oudsLocationSecurityGroupCustomizerTest.java | 112 ++++----
 .../networking/SecurityGroupLiveTest.java       |  32 ---
 ...aredLocationSecurityGroupCustomizerTest.java |   2 +-
 .../test/location/SecurityGroupLiveTest.java    | 229 +++++++++++++++
 7 files changed, 682 insertions(+), 239 deletions(-)
----------------------------------------------------------------------