You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2019/09/15 16:30:29 UTC

[logging-log4j2] 01/02: Use Collection::addAll

This is an automated email from the ASF dual-hosted git repository.

mattsicker pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit f60f528cd0a70a14564f332b4c2b4bc4940510ab
Author: Matt Sicker <bo...@gmail.com>
AuthorDate: Sat Sep 14 16:55:05 2019 -0500

    Use Collection::addAll
    
    Signed-off-by: Matt Sicker <bo...@gmail.com>
---
 .../main/java/org/apache/logging/log4j/plugins/util/TypeUtil.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/TypeUtil.java b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/TypeUtil.java
index e2bb462..6adf661 100644
--- a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/TypeUtil.java
+++ b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/TypeUtil.java
@@ -18,6 +18,7 @@ package org.apache.logging.log4j.plugins.util;
 
 import java.lang.reflect.*;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Objects;
 
@@ -49,9 +50,7 @@ public final class TypeUtil {
     public static List<Field> getAllDeclaredFields(Class<?> cls) {
         final List<Field> fields = new ArrayList<>();
         while (cls != null) {
-            for (final Field field : cls.getDeclaredFields()) {
-                fields.add(field);
-            }
+            fields.addAll(Arrays.asList(cls.getDeclaredFields()));
             cls = cls.getSuperclass();
         }
         return fields;