You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/08 12:14:17 UTC

[GitHub] [iceberg] openinx commented on a change in pull request #3857: Flink 1.13: Add SerializableTable test cases.

openinx commented on a change in pull request #3857:
URL: https://github.com/apache/iceberg/pull/3857#discussion_r780663479



##########
File path: flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java
##########
@@ -67,6 +71,16 @@
   private TestHelpers() {
   }
 
+  public static <T> T roundTripKryoSerialize(Class<T> clazz, T table) throws IOException {

Review comment:
       I put this round trip kryo serialize method in this flink TestHelpers, because I think other object that needs to validate kyro issues can also share this method.  In the previous `TestManifestFileSerialization` for example,  it's good to share this method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org