[GitHub] [ozone] adoroszlai commented on a diff in pull request #4921: HDDS-8879. Cleanup SecurityConfig and related class initialization

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #4921:
URL: https://github.com/apache/ozone/pull/4921#discussion_r1235802219


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -472,31 +470,6 @@ public static SCMSecurityProtocolClientSideTranslatorPB getScmSecurityClient(
             ugi == null ? UserGroupInformation.getCurrentUser() : ugi));
   }
 
-  public static SCMSecurityProtocolClientSideTranslatorPB

Review Comment:
   > We can get ConfigurationSource from SecurityConfig.getConfiguration().
   
   After this change we cannot, this method is being removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org