You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by di...@apache.org on 2004/07/04 19:28:19 UTC
cvs commit: jakarta-commons/pool/src/java/org/apache/commons/pool/impl GenericObjectPool.java
dirkv 2004/07/04 10:28:19
Modified: pool/src/java/org/apache/commons/pool/impl
GenericObjectPool.java
Log:
Bugzilla Bug 28619: GenericObjectPool: Swallowed Exception
- improve error messages
Revision Changes Path
1.34 +4 -4 jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Index: GenericObjectPool.java
===================================================================
RCS file: /home/cvs/jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericObjectPool.java,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- GenericObjectPool.java 29 Jun 2004 20:03:02 -0000 1.33
+++ GenericObjectPool.java 4 Jul 2004 17:28:19 -0000 1.34
@@ -741,7 +741,7 @@
// allow new object to be created
break;
case WHEN_EXHAUSTED_FAIL:
- throw new NoSuchElementException();
+ throw new NoSuchElementException("Pool exhausted");
case WHEN_EXHAUSTED_BLOCK:
try {
if(_maxWait <= 0) {
@@ -758,7 +758,7 @@
continue; // keep looping
}
default:
- throw new IllegalArgumentException("whenExhaustedAction " + _whenExhaustedAction + " not recognized.");
+ throw new IllegalArgumentException("WhenExhaustedAction property " + _whenExhaustedAction + " not recognized.");
}
}
}
@@ -786,7 +786,7 @@
try {
_factory.activateObject(pair.value);
if(_testOnBorrow && !_factory.validateObject(pair.value)) {
- throw new Exception("validateObject failed");
+ throw new Exception("ValidateObject failed");
}
return pair.value;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org