You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/14 03:48:43 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request, #19466: (1.15) Fix the remaining licence issues on 1.15
gaoyunhaii opened a new pull request, #19466:
URL: https://github.com/apache/flink/pull/19466
## What is the purpose of the change
This PR fixes the remaining licence issues in 1.15. I'll pick the PR to master after it is accepted.
## Brief change log
- Fix the wrong licence of the SQL Pulsar issue
- Remove unused entries from Kinesis and elasticsearch7 connector.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a diff in pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
Posted by GitBox <gi...@apache.org>.
dawidwys commented on code in PR #19466:
URL: https://github.com/apache/flink/pull/19466#discussion_r850160620
##########
flink-connectors/flink-sql-connector-pulsar/src/main/resources/META-INF/NOTICE:
##########
@@ -10,8 +10,12 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.pulsar:pulsar-client-admin-api:2.9.1
- org.apache.pulsar:pulsar-client-all:2.9.1
- org.apache.pulsar:pulsar-client-api:2.9.1
+- org.slf4j:jul-to-slf4j:1.7.25
+
+This project bundles the following dependencies under the MIT license.
Review Comment:
Should this be `BouncyCastle` license?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19466:
URL: https://github.com/apache/flink/pull/19466#discussion_r850167309
##########
flink-connectors/flink-sql-connector-pulsar/src/main/resources/META-INF/NOTICE:
##########
@@ -10,8 +10,12 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.pulsar:pulsar-client-admin-api:2.9.1
- org.apache.pulsar:pulsar-client-all:2.9.1
- org.apache.pulsar:pulsar-client-api:2.9.1
+- org.slf4j:jul-to-slf4j:1.7.25
+
+This project bundles the following dependencies under the MIT license.
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #19466:
URL: https://github.com/apache/flink/pull/19466#issuecomment-1099369913
Very thanks @dawidwys @zentol for the review! Will merge~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on code in PR #19466:
URL: https://github.com/apache/flink/pull/19466#discussion_r850246040
##########
flink-connectors/flink-sql-connector-pulsar/src/main/resources/META-INF/NOTICE:
##########
@@ -10,8 +10,12 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.pulsar:pulsar-client-admin-api:2.9.1
- org.apache.pulsar:pulsar-client-all:2.9.1
- org.apache.pulsar:pulsar-client-api:2.9.1
+- org.slf4j:jul-to-slf4j:1.7.25
+
+This project bundles the following dependencies under the MIT license.
Review Comment:
Got that, I changed it to the BouncyCastle licence now~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
URL: https://github.com/apache/flink/pull/19466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19466: (1.15) [FLINK-27231][FLINK-27230][FLINK-27233] Fix the remaining licence issues on 1.15
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19466:
URL: https://github.com/apache/flink/pull/19466#issuecomment-1098683800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "acf8a13378407d05eef02e812d5dbcda9d2dd943",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acf8a13378407d05eef02e812d5dbcda9d2dd943",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acf8a13378407d05eef02e812d5dbcda9d2dd943 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org