You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "nathaniel-daniel (via GitHub)" <gi...@apache.org> on 2024/05/21 03:06:15 UTC

[PR] Fix compilation of datafusion-cli on 32bit targets [datafusion]

nathaniel-daniel opened a new pull request, #10594:
URL: https://github.com/apache/datafusion/pull/10594

   ## Which issue does this PR close?
   Closes #10552.
   
   ## Rationale for this change
   This PR fixes compilation of the datafusion-cli crate on 32bit targets. 
   
   ## What changes are included in this PR?
   A constant assumed that a usize was at least 64 bits wide. I changed the constant type to be a u64, before translating it into a usize later on, throwing an error if it overflows.
   
   ## Are these changes tested?
   These changes are not tested. I assumed adding CI for 32bit targets was too invasive for this PR.
   
   ## Are there any user-facing changes?
   There should be no user-facing changes or breaking changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix compilation of datafusion-cli on 32bit targets [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #10594:
URL: https://github.com/apache/datafusion/pull/10594


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix compilation of datafusion-cli on 32bit targets [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10594:
URL: https://github.com/apache/datafusion/pull/10594#issuecomment-2123297797

   Thank you @nathaniel-daniel  and @jonahgao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org