You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/11 10:04:44 UTC

[GitHub] [spark] HyukjinKwon commented on pull request #33702: [SPARK-34808][SQL][FOLLOWUP] Remove canPlanAsBroadcastHashJoin check in EliminateOuterJoin

HyukjinKwon commented on pull request #33702:
URL: https://github.com/apache/spark/pull/33702#issuecomment-896689983


   @wankunde can you create a separate JIRA for it? I assume you target to update aggregate functions together, right?
   
   The example in the PR description doesn't contain `max` BTW. It has to be fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org