[jira] [Commented] (OAK-2879) Compaction should check for required disk space before running

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940971#comment-14940971 ] 

Michael Dürig commented on OAK-2879:
------------------------------------

General approach looks good. However we need to avoid using {{Thread.interrupt}} as it can interfere with NIO (see OAK-2609) and come up with a custom approach of signalling interruption. 

Nice thing is that OAK-3290 will also profit from this work!

Regarding the additional logging, we should probably change the wording in "transient changes will be discarded at next cleanup" as "transient changes" will confuse people. 




> Compaction should check for required disk space before running
> --------------------------------------------------------------
>
>                 Key: OAK-2879
>                 URL: https://issues.apache.org/jira/browse/OAK-2879
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Francesco Mari
>              Labels: compaction, doc-impacting, gc, resilience
>             Fix For: 1.3.8
>
>         Attachments: OAK-2879-01.patch
>
>
> In the worst case compaction doubles the repository size while running. As this is somewhat unexpected we should check whether there is enough free disk space before running compaction and log a warning otherwise. This is to avoid a common source of running out of disk space and ending up with a corrupted repository. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)