You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/27 03:51:18 UTC
[GitHub] [spark] Peng-Lei opened a new pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Make exception `private[spark]`
Peng-Lei opened a new pull request #33856:
URL: https://github.com/apache/spark/pull/33856
### What changes were proposed in this pull request?
Mark the exception added `private[spark`
according [comments](https://github.com/apache/spark/pull/33573#discussion_r696324962)
### Why are the changes needed?
[comments](https://github.com/apache/spark/pull/33573#discussion_r696324962)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
existed ut testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906970031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47336/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697244379
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
users might want to do a specific action for a specific type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906904405
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907471098
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907716059
**[Test build #142845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142845/testReport)** for PR 33856 at commit [`d59ccd7`](https://github.com/apache/spark/commit/d59ccd781f1aca97e7ba8d703224d7b665506471).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33856:
URL: https://github.com/apache/spark/pull/33856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697253372
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
How about use `ClassNotFoundException` instead of `SparkClassNotFoundException` to do the specific action for users? We just define the new exception that start with `Spark` and mix SparkThrowable into a base Exception type. So It's one-to-one with base exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906970031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47336/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906932361
> SparkException is not newly added, I'm a bit worried about changing it.
Right, let's leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906906169
cc @cloud-fan and @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697183289
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
Instead of letting the user know about various kind of internal exception, Unified catch `Throwable` maybe simple?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906945316
**[Test build #142834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142834/testReport)** for PR 33856 at commit [`d59ccd7`](https://github.com/apache/spark/commit/d59ccd781f1aca97e7ba8d703224d7b665506471).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907238424
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142834/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907471098
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907720650
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906920390
Do we need to make `SparkException` private as well, regarding the comment https://github.com/apache/spark/pull/33824#discussion_r695054945
cc @karenfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907237371
**[Test build #142834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142834/testReport)** for PR 33856 at commit [`d59ccd7`](https://github.com/apache/spark/commit/d59ccd781f1aca97e7ba8d703224d7b665506471).
* This patch **fails from timeout after a configured wait of `500m`**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906945316
**[Test build #142834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142834/testReport)** for PR 33856 at commit [`d59ccd7`](https://github.com/apache/spark/commit/d59ccd781f1aca97e7ba8d703224d7b665506471).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907729531
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142845/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907114755
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906904405
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697163552
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
Should we maybe expose this so users can explicitly catch the exception? We can only hide constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906965652
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47336/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907719999
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907727520
**[Test build #142845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142845/testReport)** for PR 33856 at commit [`d59ccd7`](https://github.com/apache/spark/commit/d59ccd781f1aca97e7ba8d703224d7b665506471).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906921718
`SparkException` is not newly added, I'm a bit worried about changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907931512
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907114755
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697940091
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
okie, I am fine as long as users can catch the specific exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907729531
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142845/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907720650
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906937068
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697560420
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
I agree that we want to keep this package-private; the user can catch `ClassNotFoundException` or `SparkThrowable` as discussed here https://github.com/apache/spark/pull/33824#discussion_r695054945. It's a pretty vague exception type, so I think it's more likely they'll want to catch by the error class or SQLSTATE from the `SparkThrowable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907716059
**[Test build #142845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142845/testReport)** for PR 33856 at commit [`d59ccd7`](https://github.com/apache/spark/commit/d59ccd781f1aca97e7ba8d703224d7b665506471).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-906964774
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47336/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907713780
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907931512
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33856:
URL: https://github.com/apache/spark/pull/33856#issuecomment-907238424
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142834/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #33856: [SPARK-36336][SQL][FOLLOWUP] Mark exception `private[spark]`
Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on a change in pull request #33856:
URL: https://github.com/apache/spark/pull/33856#discussion_r697253372
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -90,7 +90,7 @@ private[spark] class SparkArithmeticException(errorClass: String, messageParamet
/**
* Class not found exception thrown from Spark with an error class.
*/
-class SparkClassNotFoundException(
+private[spark] class SparkClassNotFoundException(
Review comment:
How about use `ClassNotFoundException` instead of `SparkClassNotFoundException` to do the specific action? We just define the new exception that start with `Spark` and mix SparkThrowable into a base Exception type. So It's one-to-one with base exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org