You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/19 20:13:26 UTC

[GitHub] [iceberg] jackye1995 commented on pull request #5081: AWS: add skip name validation to isValidIdentifier

jackye1995 commented on PR #5081:
URL: https://github.com/apache/iceberg/pull/5081#issuecomment-1159803676

   Overall looks good! Just to avoid we miss any additional edge case, can you add an integration test just to test end to end?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org