You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2023/03/01 14:41:59 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request, #9477: QUIC: Make sure the following configuration gets set into the quiche impl.
brbzull0 opened a new pull request, #9477:
URL: https://github.com/apache/trafficserver/pull/9477
Just passing them into the quche lib.
```yaml
ts:
quic:
no_activity_timeout_in: 1000
initial_max_data_in: 60000
initial_max_stream_data_bidi_local_in: 1000
initial_max_stream_data_bidi_remote_in: 1000
initial_max_stream_data_uni_in: 4000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450451001
> is ts.quic.no_activity_timeout_in the right field to be used for the max_idle_timeout set by quiche_config_set_max_idle_timeout?
Yes, it is. I'm wondering if the setting should take milliseconds. It's millisecond on the spec but we use seconds for most of ATS settings. `proxy.config.http.accept_no_activity_timeout` for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450464138
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1452516241
Thinking about the unit specifier here - #9485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 merged pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 merged PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450634051
> Let's keep this PR simple and think about the unit specifier at somewhere else.
sure.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450544749
Hmm, I like the idea but I'm not sure if that works for timeouts. It's kinda obvious that we cannot set 500 milli-bytes nor 8.3 bytes as a file/buffer size. Its minimum unit is obviously byte. On the other hand, 125 milliseconds can make sense for some timeout, but users don't know the actual internal precision unless the documentation says it.
I found the setting currently takes millisecond. I guess I used the unit which the spec use without thinking about it much. Let's keep this PR simple and think about the unit specifier at somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450385775
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the following configuration gets set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450266213
@maskit is `ts.quic.no_activity_timeout_in` the right field to be used for the `max_idle_timeout` set by `quiche_config_set_max_idle_timeout`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450463004
> > is ts.quic.no_activity_timeout_in the right field to be used for the max_idle_timeout set by quiche_config_set_max_idle_timeout?
>
> Yes, it is. I'm wondering if the setting should take milliseconds. It's millisecond on the spec but we use seconds for most of ATS settings. `proxy.config.http.accept_no_activity_timeout` for example.
I think we can do something for this, and instead of be tight to a particular unit we can actually support multipliers like we do for [other](https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.yaml.en.html#values) units like M,K,G
so eventually we can say:
```yaml
ts:
quic:
no_activity_timeout_in: 1s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the some of the quic configs get set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450701192
[approve ci clang-analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #9477: QUIC: Make sure the following configuration gets set into the quiche impl.
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9477:
URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450304659
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org