[GitHub] maoling opened a new pull request #624: ZOOKEEPER-3108:use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir

[GitBox <gi...@apache.org>]

maoling opened a new pull request #624: ZOOKEEPER-3108:use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir
URL: https://github.com/apache/zookeeper/pull/624
 
 
   - use a new property `myid` in the `zoo.cfg` to substitute for `myid `file,If the unique id is both set in the `myid` of `zoo.cfg` and `myid` file,they must be the same value.
   - I had tested this patch in my docker in standalone and qurom mode with mixed `myid` file and the `myid`property in the zoo.cfg.
     it has any intrude,totally backwards compatibility,branch3.4 can still use myid file, but branch 3.5+,
     suggest to use `myid `in the zoo.cfg
   - the related UTs `ZooKeeperServerMainTest.testStandalone()` and `QuorumPeerMainTest.testQuorum() `have passed,before reviewing,let's listen to the QA report in case of something I miss 
   - more details and disscusion in [ZOOKEEPER-3108](https://issues.apache.org/jira/browse/ZOOKEEPER-3108) 
   - Let me list why this is needed:
   **1.** put the `myid` which's about the conf of server in the `dataDir` is not a good idea.if I want to `rm -rf `the data in this directory manually,I will delete the `myid` file by mistake.
   **2.** conf like this will be easy-to-read,and tell me who I am, just like `kafka's` `server.properties` does.
     ``` 
     myid = 2
     ---*******---
     server.1=172.17.0.2:2888:3888
     server.2=172.17.0.2:12888:13888
     server.3=172.17.0.2:22888:23888
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services