You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/31 06:22:53 UTC

[GitHub] [arrow] kshitij12345 commented on a diff in pull request #14550: ARROW-17301: [C++] Implement compute function "binary_slice"

kshitij12345 commented on code in PR #14550:
URL: https://github.com/apache/arrow/pull/14550#discussion_r1009064077


##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -2119,6 +2119,96 @@ TYPED_TEST(TestStringKernels, SliceCodeunitsNegPos) {
 
 #endif  // ARROW_WITH_UTF8PROC
 
+TYPED_TEST(TestBaseBinaryKernels, SliceBytesBasic) {

Review Comment:
   Inspired from `utf8_slice_codeunits` tests
   
   https://github.com/apache/arrow/blob/884e81bf2ffd410cbffac9727b94617532c8d915/cpp/src/arrow/compute/kernels/scalar_string_test.cc#L2013



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org