You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/11/28 22:41:23 UTC

[PR] Enable triggering postcommit via specific file [beam]

Abacn opened a new pull request, #29549:
URL: https://github.com/apache/beam/pull/29549

   Workaround #28909 
   
   Enable to trigger a PostCommit from pull request by touching a file named "<workflow_name>.json" (/json to get around with RAT PreCommit), as a simple workaround of #28909.
   
   In this way the last piece of gap (comment trigger) is partially fixed and we can shutdown all Jenkins jobs.
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #29549:
URL: https://github.com/apache/beam/pull/29549#discussion_r1409941176


##########
.github/workflows/README.md:
##########
@@ -271,7 +271,6 @@ Please note that jobs with matrix need to have matrix element in the comment. Ex
 
 | Workflow name | Matrix | Trigger Phrase | Cron Status |
 |:-------------:|:------:|:--------------:|:-----------:|
-| [ PostCommit BeamMetrics Publish ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml) | N/A |`Run Beam Metrics Deployment`| [![.github/workflows/beam_PostCommit_BeamMetrics_Publish.yml](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml/badge.svg?event=schedule)](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml?query=event%3Aschedule)
 | [ PostCommit Go ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml) | N/A |`Run Go PostCommit`| [![.github/workflows/beam_PostCommit_Go.yml](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml/badge.svg?event=schedule)](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml?query=event%3Aschedule) |

Review Comment:
   updated README.md replacing trigger phrase->trigger file, added instructions on how to manually trigger precommit and postcommits



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #29549:
URL: https://github.com/apache/beam/pull/29549#discussion_r1410887757


##########
.github/workflows/README.md:
##########
@@ -192,6 +192,8 @@ Please note that jobs with matrix need to have matrix element in the comment. Ex
 
 ### PreCommit Jobs
 
+PreCommit Jobs run in a schedule and also get triggered in a PR if relevant sources has changed. To manually trigger certain PreCommit job, comment with the Trigger Phrase (listed below) in the PR.

Review Comment:
   Maybe add something for postcommit jobs here with instructions on how to find the magic file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #29549:
URL: https://github.com/apache/beam/pull/29549#discussion_r1410972312


##########
.github/workflows/README.md:
##########
@@ -192,6 +192,8 @@ Please note that jobs with matrix need to have matrix element in the comment. Ex
 
 ### PreCommit Jobs
 
+PreCommit Jobs run in a schedule and also get triggered in a PR if relevant sources has changed. To manually trigger certain PreCommit job, comment with the Trigger Phrase (listed below) in the PR.

Review Comment:
   PostCommit instructions is in PostCommit subsection: https://github.com/apache/beam/blob/6efa27c6e08513ae5b3667d9efcaa6c660525cfc/.github/workflows/README.md#postcommit-jobs 
   
   yeah its not quite easy to find given the long README file. Will also mention it in the #comment-triggering-support section



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #29549:
URL: https://github.com/apache/beam/pull/29549#discussion_r1409940792


##########
.github/workflows/beam_Java_JMH.yml:
##########
@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 0 * * 0'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', 'beam_Java_JMH.json']

Review Comment:
   added prefix .github/trigger_files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #29549:
URL: https://github.com/apache/beam/pull/29549#discussion_r1408507954


##########
.github/workflows/README.md:
##########
@@ -271,7 +271,6 @@ Please note that jobs with matrix need to have matrix element in the comment. Ex
 
 | Workflow name | Matrix | Trigger Phrase | Cron Status |
 |:-------------:|:------:|:--------------:|:-----------:|
-| [ PostCommit BeamMetrics Publish ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml) | N/A |`Run Beam Metrics Deployment`| [![.github/workflows/beam_PostCommit_BeamMetrics_Publish.yml](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml/badge.svg?event=schedule)](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml?query=event%3Aschedule)

Review Comment:
   BeamMetrics Publish and Website Publish are not really "postcommit" or test suites. It **deploys** the Beam website or **deploys** the community metrics dashboard. They should not have comment trigger (which could be used to attack beam website). So renamed them and move to "other" category.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #29549:
URL: https://github.com/apache/beam/pull/29549#issuecomment-1834164218

   > Oh, we should probably do the same for benchmarks as well
   
   The hope is we can still have the comment trigger in the near future, which is more convenient for developers and reviewers (reviewer can also run the test by comment), as @volatilemolotov working on GitHub App approach. If decided this being long time solution then we can add it to load tests and performance tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #29549:
URL: https://github.com/apache/beam/pull/29549#issuecomment-1834108906

   Oh, we should probably do the same for benchmarks as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29549:
URL: https://github.com/apache/beam/pull/29549#issuecomment-1830933340

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #29549:
URL: https://github.com/apache/beam/pull/29549#discussion_r1409499314


##########
.github/workflows/README.md:
##########
@@ -271,7 +271,6 @@ Please note that jobs with matrix need to have matrix element in the comment. Ex
 
 | Workflow name | Matrix | Trigger Phrase | Cron Status |
 |:-------------:|:------:|:--------------:|:-----------:|
-| [ PostCommit BeamMetrics Publish ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml) | N/A |`Run Beam Metrics Deployment`| [![.github/workflows/beam_PostCommit_BeamMetrics_Publish.yml](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml/badge.svg?event=schedule)](https://github.com/apache/beam/actions/workflows/beam_PostCommit_BeamMetrics_Publish.yml?query=event%3Aschedule)
 | [ PostCommit Go ](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml) | N/A |`Run Go PostCommit`| [![.github/workflows/beam_PostCommit_Go.yml](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml/badge.svg?event=schedule)](https://github.com/apache/beam/actions/workflows/beam_PostCommit_Go.yml?query=event%3Aschedule) |

Review Comment:
   We need to also update all the postcommits in this file to not have trigger phrases listed. Ideally we'd list the file to modify instead.
   
   We should also modify the part that talks about trigger phrases at the top and explain this approach.



##########
.github/workflows/beam_Java_JMH.yml:
##########
@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 0 * * 0'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', 'beam_Java_JMH.json']

Review Comment:
   Our guidance could even be to check them in, it does no harm.



##########
.github/workflows/beam_Java_JMH.yml:
##########
@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 0 * * 0'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', 'beam_Java_JMH.json']

Review Comment:
   Can we put these in a subfolder? Maybe `.github/trigger_files`? That way if they accidentally get checked in it doesn't cause issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable triggering postcommit via specific file [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #29549:
URL: https://github.com/apache/beam/pull/29549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org