You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/16 18:45:35 UTC
[GitHub] [fineract-cn-mobile] varsvat opened a new pull request #144: Fix: added the functionality of not directly exiting the stepperLayout on pressing back button in Group Edit screen
varsvat opened a new pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144
Fixes [FINCN-274](https://issues.apache.org/jira/browse/FINCN-274)
Before fix:
https://user-images.githubusercontent.com/53621853/111363047-8e53ef00-86b5-11eb-904c-a3311a439bf2.mp4
After fix:
https://user-images.githubusercontent.com/53621853/111363109-a461af80-86b5-11eb-8db2-fb8f93e5ed52.mp4
In Group Edit screen , the StepperLyaout has been implemented and right now, if the user presses back button, no matter if the user is on 3rd page or editing something, he will directly exit the edit screen.
After Fix: Now , the user will be taken to the first tab of editing screen and then he can go back which is implemented in various real-life projects and is much better acc. to UX
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [ ] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [ ] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800861684
Yes, I am a little busy right now . Will merge it in some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800840368
> Hey, @varsvat sorry man i was little bit stressed last night that's why I was stupidly not accepting anything that you were saying. I'll close that PR soon and make a PR to your branch. You just have to merge it to your branch and please after that can you squash all commits into one. Let's give new day a fresh start.
No Problem Kinar. It's fine :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800862646
> Yes, I am a little busy right now . Will merge it in some time.
No problem, just confirming that you received it👍.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800846811
Hey @varsvat, I made the PR to your FINCN-274 branch go see it and merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #144: Fix-274: added the functionality of not directly exiting the stepperLayout on pressing back button in Group Edit screen
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800769615
> @varsvat looks good but can we add dialog to confirm before exit? It would be better not to suddenly leave. What do you say?
Yeah sure, will push a commit to this PR with the changes incorporated and implementing this in all the StepperLayout screens
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800858616
> Hey @varsvat, I made the PR to your FINCN-274 branch go see it and merge it.
Hey varun, did you see my PR? please merge it in your branch when you have time:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800772146
Added Dialog box and Implemented this feature in other Editing screens also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #144: Fix-274: Exiting pattern corrected in all the edit screens, implemented with StepperLayout.
Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #144:
URL: https://github.com/apache/fineract-cn-mobile/pull/144#issuecomment-800837896
Hey, @varsvat sorry man i was little bit stressed last night that's why I was stupidly not accepting anything that you were saying. I'll close that PR soon and make a PR to your branch. You just have to merge it to your branch and please after that can you squash all commits into one😊. Let's give new day a fresh start😄.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org