You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/03 06:27:26 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #17103: [FLINK-24069][tests] Fail IgnoreInFlightData test when there is not enough data for it for all checkpoints not only the first one

dawidwys commented on a change in pull request #17103:
URL: https://github.com/apache/flink/pull/17103#discussion_r701613277



##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -68,13 +70,15 @@
                             .build());
 
     @Rule public final SharedObjects sharedObjects = SharedObjects.create();
+    @Rule public Timeout timeout = new Timeout(30, TimeUnit.SECONDS);

Review comment:
       Since some time we discourage timeouts in JUnit tests. Please see `Avoid timeouts in JUnit tests` here https://flink.apache.org/contributing/code-style-and-quality-common.html#design-for-testability 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org