You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2024/04/15 16:26:29 UTC

[PR] fix: backtracking on adding docker/.env-local for docker-compose [superset]

mistercrunch opened a new pull request, #28039:
URL: https://github.com/apache/superset/pull/28039

   As reported here https://github.com/apache/superset/issues/28026, in
   https://github.com/apache/superset/pull/27953 I added support for a
   supplemental `docker/.env-local` override file, not thinking it was
   going to be required upon starting docker-compose. I thought I had
   tested that while switching branches but somehow didn't test that
   docker-compose would simply boot up in the absence of that file.
   
   Since this is confusing to most, and we don't really have a script
   I can latch onto to `touch docker/.env-local` for now, i decided
   to backtrack and simply  remove the convenience "feature".
   People should find an alternate way to alter their environment
   somehow before starting the service.
   
   I added a bit of documentation to point to an existing mechanism
   around providing a `docker/pythonpath_dev/superset_config_docker.py`
   file, which existed in the logic but wasn't clearly documented. This
   solves for my use case where I was working a PR adding features
   around Slack, where I wanted to provide an API key configuration
   without risks of commiting/pushing it back to the repo.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: support docker/.env-local for docker-compose [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #28039:
URL: https://github.com/apache/superset/pull/28039#discussion_r1566168336


##########
.gitignore:
##########
@@ -110,7 +110,6 @@ release.json
 messages.mo
 
 docker/requirements-local.txt
-docker/.env-local

Review Comment:
   turns out that's covered by `docker/*local*` bellow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: support docker/.env-local for docker-compose [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #28039:
URL: https://github.com/apache/superset/pull/28039#issuecomment-2059431385

   NICE! I'm feeling like CI / docker / docker-compose is getting to a pretty good place. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: support docker/.env-local for docker-compose [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28039:
URL: https://github.com/apache/superset/pull/28039#issuecomment-2057426071

   @artofcomputing please feel free to leave a review if you're so inclined :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: support docker/.env-local for docker-compose [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #28039:
URL: https://github.com/apache/superset/pull/28039#issuecomment-2057444308

   docker-compose is getting very usable for dev workflows - having it boot fast from my previous PR makes it much more viable too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: support docker/.env-local for docker-compose [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #28039:
URL: https://github.com/apache/superset/pull/28039


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org