You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/07/21 03:31:50 UTC
[PR] test(workflow-core): cover parsePhysicalAddress [texera]
Ma77Ball opened a new pull request, #6697:
URL: https://github.com/apache/texera/pull/6697
### What changes were proposed in this PR?
- Add unit tests for LakeFSStorageClient.parsePhysicalAddress covering the well-formed bucket and key split.
- Cover all four throw branches: empty or blank address, malformed URI, missing host or bucket, and missing key or path.
### Any related issues, documentation, discussions?
Closes: #6696
### How was this PR tested?
- Run: `sbt "WorkflowCore/testOnly *LakeFSStorageClientSpec"`, expect all 9 tests passing.
- Test-only change; no production code is modified.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): cover parsePhysicalAddress [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6697:
URL: https://github.com/apache/texera/pull/6697#issuecomment-5029869502
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6697?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.65%. Comparing base ([`0467c76`](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6876edb`](https://app.codecov.io/gh/apache/texera/commit/6876edbe90d29511104bc3cf4c93af9996400c94?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6697 +/- ##
=========================================
Coverage 74.65% 74.65%
Complexity 3438 3438
=========================================
Files 1160 1160
Lines 45793 45793
Branches 5069 5069
=========================================
Hits 34189 34189
Misses 9953 9953
Partials 1651 1651
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.81% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `18.00% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.80% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.56% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.99% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [0467c76](https://app.codecov.io/gh/apache/texera/commit/0467c76529981b3951bceb33eedf6bcc776f16a3?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6697?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): cover parsePhysicalAddress [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6697:
URL: https://github.com/apache/texera/pull/6697#issuecomment-5029851798
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): cover parsePhysicalAddress [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6697:
URL: https://github.com/apache/texera/pull/6697#issuecomment-5029892006
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 5 worse · ⚪ 8 noise (<±5%) · 0 without baseline
> Compared against main `0467c76` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/29798748932)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🟢 | bs=10 sw=10 sl=64 | 412 | 0.251 | 23,246/29,708/29,708 us | 🟢 -14.8% / 🔴 +90.0% |
| 🔴 | bs=100 sw=10 sl=64 | 807 | 0.492 | 123,048/154,818/154,818 us | 🔴 +15.0% / 🔴 +46.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 944 | 0.576 | 1,061,509/1,088,914/1,088,914 us | ⚪ within ±5% / 🔴 +8.9% |
<details><summary>Baseline details</summary>
Latest main `0467c76` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 412 tuples/sec | 405 tuples/sec | 767.23 tuples/sec | +1.7% | -46.3% |
| bs=10 sw=10 sl=64 | MB/s | 0.251 MB/s | 0.247 MB/s | 0.468 MB/s | +1.6% | -46.4% |
| bs=10 sw=10 sl=64 | p50 | 23,246 us | 24,418 us | 12,705 us | -4.8% | +83.0% |
| bs=10 sw=10 sl=64 | p95 | 29,708 us | 34,877 us | 15,633 us | -14.8% | +90.0% |
| bs=10 sw=10 sl=64 | p99 | 29,708 us | 34,877 us | 20,214 us | -14.8% | +47.0% |
| bs=100 sw=10 sl=64 | throughput | 807 tuples/sec | 858 tuples/sec | 1,001 tuples/sec | -5.9% | -19.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.492 MB/s | 0.524 MB/s | 0.611 MB/s | -6.1% | -19.5% |
| bs=100 sw=10 sl=64 | p50 | 123,048 us | 114,864 us | 99,949 us | +7.1% | +23.1% |
| bs=100 sw=10 sl=64 | p95 | 154,818 us | 134,618 us | 105,996 us | +15.0% | +46.1% |
| bs=100 sw=10 sl=64 | p99 | 154,818 us | 134,618 us | 117,999 us | +15.0% | +31.2% |
| bs=1000 sw=10 sl=64 | throughput | 944 tuples/sec | 940 tuples/sec | 1,033 tuples/sec | +0.4% | -8.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.576 MB/s | 0.574 MB/s | 0.631 MB/s | +0.3% | -8.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,061,509 us | 1,062,744 us | 974,571 us | -0.1% | +8.9% |
| bs=1000 sw=10 sl=64 | p95 | 1,088,914 us | 1,111,219 us | 1,016,467 us | -2.0% | +7.1% |
| bs=1000 sw=10 sl=64 | p99 | 1,088,914 us | 1,111,219 us | 1,048,798 us | -2.0% | +3.8% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,485.62,200,128000,412,0.251,23246.49,29707.74,29707.74
1,100,10,64,20,2479.08,2000,1280000,807,0.492,123048.09,154817.50,154817.50
2,1000,10,64,20,21185.34,20000,12800000,944,0.576,1061508.91,1088913.53,1088913.53
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-core): cover parsePhysicalAddress [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6697:
URL: https://github.com/apache/texera/pull/6697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org