You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "muralibasani (via GitHub)" <gi...@apache.org> on 2023/07/26 20:22:44 UTC
[GitHub] [kafka] muralibasani opened a new pull request, #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig
muralibasani opened a new pull request, #14106:
URL: https://github.com/apache/kafka/pull/14106
Description
This PR does the below.
- Create java version for core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala
- Update LogConfig with new constructor to handle nodeId, brokerId, zookeeper connect properties
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig [kafka]
Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1836870533
@muralibasani should you also close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] muralibasani commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig
Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1655168025
@fvaleri would like to take a look at this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1817733757
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] muralibasani commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig
Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1667819639
@mimaison would like to take a look at this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] fvaleri commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig
Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1668014997
@muralibasani sorry for the delay.
As I wrote [here](https://github.com/apache/kafka/pull/13417#pullrequestreview-1548110301), you need to remove the Scala code that you are migrating to Java. Then you need to update all references to the old Scala code and let them use the new Java code, otherwise we would have code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] muralibasani commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig
Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1685374411
@fvaleri @mimaison I tried to delete scala versions of (BrokerMetadataCheckpoint, MetaProperties, RawMetaProperties) and update all the dependencies with Java versions, but it has updates to KafkaServer, ControllerApis, RaftManager, TestKitNodes, KafkaClusterTestKit, SharedServer, ServerGenerateBrokerIdTest, TestRaftServer and a couple of more.
May I ask someone to pick up this PR/change from here as am not very comfortable making changes to those critical classes like KafkaServer, SharedServer and RaftManager ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig [kafka]
Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1828189839
@muralibasani sorry for the late reply and thanks for working on this complicated migration. I'm taking over as you requested, let's see if it possible to complete it now, or there is still some big tra that must be migrated first. I will open a new PR, so I guess you can close this and #13417.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig [kafka]
Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani closed pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig
URL: https://github.com/apache/kafka/pull/14106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org