[jira] [Commented] (SOLR-9746) Eclipse project broken due to duplicate package-info.java in LTR contrib

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654160#comment-15654160 ] 

Uwe Schindler commented on SOLR-9746:
-------------------------------------

This is a clear bug in the package structure! This will lead to problems with Java 9's module system (once we migrate to it), too. It should generally be avoided to have same Java package in different JAR files / modules. I'd suggest to rename the packages in ltr to have "ltr" in its name. If the package names are the same to work around package-protected access, this is likely to break with Java 9, too where each modular JAR file gets its own classloader.

I know we have some modules in Lucene that also share packages, but we should work on fixing them. This also causes problems with generating Javadocs, because it causes broken links.

> Eclipse project broken due to duplicate package-info.java in LTR contrib
> ------------------------------------------------------------------------
>
>                 Key: SOLR-9746
>                 URL: https://issues.apache.org/jira/browse/SOLR-9746
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Minor
>
> The eclipse project generated through {{ant eclipse}} seems to be broken, since there are errors complaining duplicate resources. The problem is that the following files have the same package and class names:
> {code}
> ./solr/core/src/java/org/apache/solr/response/transform/package-info.java
> ./solr/contrib/ltr/src/java/org/apache/solr/response/transform/package-info.java
> ./solr/core/src/java/org/apache/solr/search/package-info.java
> ./solr/contrib/ltr/src/java/org/apache/solr/search/package-info.java
> {code}
> Not sure if the idea project is affected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org