[GitHub] [spark] maropu commented on a change in pull request #24118: [SPARK-26736][SQL] if filter condition `And` has non-determined sub function it does not do partition prunning

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #24118: [SPARK-26736][SQL] if filter condition `And` has non-determined sub function it does not do partition prunning
URL: https://github.com/apache/spark/pull/24118#discussion_r266868593
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
 ##########
 @@ -63,10 +63,27 @@ object PhysicalOperation extends PredicateHelper {
         val substitutedFields = fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]]
         (Some(substitutedFields), filters, other, collectAliases(substitutedFields))
 
-      case Filter(condition, child) if condition.deterministic =>
-        val (fields, filters, other, aliases) = collectProjectsAndFilters(child)
-        val substitutedCondition = substitute(aliases)(condition)
-        (fields, filters ++ splitConjunctivePredicates(substitutedCondition), other, aliases)
+      case filter: Filter if filter.condition.deterministic || filter.condition.isInstanceOf[And] =>
 
 Review comment:
   `PhysicalOperation` is used in many places, so have you checked this change has no side-effect for the other behivours?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org