You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/22 11:41:17 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #10392: fix(api): fixes perf on charts and introduces sorting by db on datasets
dpgaspar opened a new pull request #10392:
URL: https://github.com/apache/incubator-superset/pull/10392
### SUMMARY
Fixes a performance bug on charts and introduces sorting by database on datasets
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #10392: fix(api): fixes perf on charts and introduces sorting by db on datasets
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10392:
URL: https://github.com/apache/incubator-superset/pull/10392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10392: fix(api): fixes perf on charts and introduces sorting by db on datasets
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10392:
URL: https://github.com/apache/incubator-superset/pull/10392#issuecomment-662410827
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=h1) Report
> Merging [#10392](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/961108625e805022d17125e8c52e88615645e3a2&el=desc) will **decrease** coverage by `0.77%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10392 +/- ##
==========================================
- Coverage 70.52% 69.75% -0.78%
==========================================
Files 603 196 -407
Lines 32421 19025 -13396
Branches 3297 0 -3297
==========================================
- Hits 22865 13270 -9595
+ Misses 9452 5755 -3697
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.75% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.45% <ø> (-0.05%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.14% <ø> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `84.65% <100.00%> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | | |
| [...end/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnRHJvcHBhYmxlLmpzeA==) | | |
| [superset-frontend/src/components/ModalTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyLmpzeA==) | | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
| [.../src/dashboard/components/menu/PopoverDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvUG9wb3ZlckRyb3Bkb3duLmpzeA==) | | |
| ... and [399 more](https://codecov.io/gh/apache/incubator-superset/pull/10392/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=footer). Last update [9611086...53e4c0c](https://codecov.io/gh/apache/incubator-superset/pull/10392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org