You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2007/12/18 18:56:43 UTC

[jira] Created: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Add a 'forrest.home' property for the 'docs' target in build.xml
----------------------------------------------------------------

                 Key: HADOOP-2457
                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
             Project: Hadoop
          Issue Type: Improvement
          Components: documentation
            Reporter: Arun C Murthy
            Assignee: Arun C Murthy
            Priority: Minor
             Fix For: 0.16.0


I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.

$ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by Nigel Daley <nd...@yahoo-inc.com>.
Patch process has been updated.  Patches run between this commit and  
now have failed with "-1" on the core tests.  I'll leave it to  
individuals to resubmit their patches.

Nige


On Dec 20, 2007, at 12:24 AM, Arun C Murthy (JIRA) wrote:

>
>      [ https://issues.apache.org/jira/browse/HADOOP-2457? 
> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Arun C Murthy updated HADOOP-2457:
> ----------------------------------
>
>     Resolution: Fixed
>         Status: Resolved  (was: Patch Available)
>
> Thanks for the review Nigel, could you please fix the patch  
> process? Thanks!
>
> I just committed this.
>
>> Add a 'forrest.home' property for the 'docs' target in build.xml
>> ----------------------------------------------------------------
>>
>>                 Key: HADOOP-2457
>>                 URL: https://issues.apache.org/jira/browse/ 
>> HADOOP-2457
>>             Project: Hadoop
>>          Issue Type: Improvement
>>          Components: documentation
>>            Reporter: Arun C Murthy
>>            Assignee: Arun C Murthy
>>            Priority: Minor
>>             Fix For: 0.16.0
>>
>>         Attachments: HADOOP-2457_1_20071218.patch,  
>> HADOOP-2457_2_20071220.patch
>>
>>
>> I propose we add a *forrest.home* property which is used as the  
>> base for the Apache Forrest installation for the _docs_ target,  
>> currently it relies on forrest being on the PATH.
>> $ ant -Dforrest.home=<forrest installation> docs
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>


[jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2457:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thanks for the review Nigel, could you please fix the patch process? Thanks!

I just committed this.

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch, HADOOP-2457_2_20071220.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2457:
----------------------------------

    Status: Patch Available  (was: Open)

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2457:
----------------------------------

    Attachment: HADOOP-2457_1_20071218.patch

Straight-forward patch...

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553582 ] 

Nigel Daley commented on HADOOP-2457:
-------------------------------------

+1 code review

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch, HADOOP-2457_2_20071220.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552856 ] 

Hadoop QA commented on HADOOP-2457:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12371885/HADOOP-2457_1_20071218.patch
against trunk revision r605277.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1384/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1384/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1384/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1384/console

This message is automatically generated.

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2457:
----------------------------------

    Status: Patch Available  (was: Open)

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch, HADOOP-2457_2_20071220.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553508 ] 

Hadoop QA commented on HADOOP-2457:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12371982/HADOOP-2457_2_20071220.patch
against trunk revision r605675.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1397/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1397/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1397/console

This message is automatically generated.

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch, HADOOP-2457_2_20071220.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2457:
----------------------------------

    Status: Open  (was: Patch Available)

> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552863 ] 

Arun C Murthy commented on HADOOP-2457:
---------------------------------------

The build failed since, currently, we didn't pass *forrest.home* while building:

{noformat}
docs:

BUILD FAILED
/export/home/hudson/hudson/jobs/Hadoop-Patch/workspace/trunk/build.xml:613: Execute failed: java.io.IOException: /bin/forrest: not found
{noformat}


> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2457) Add a 'forrest.home' property for the 'docs' target in build.xml

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2457:
----------------------------------

    Attachment: HADOOP-2457_2_20071220.patch

Slightly improved patch which prints a diagnostic message when {{forrest.home}} isn't defined:

{noformat}
$ ant docs
Buildfile: build.xml

forrest.check:

BUILD FAILED
HADOOP-2352/build.xml:621: 'forrest.home' is not defined. Please pass -Dforrest.home=<base of Apache Forrest installation> to Ant on the command-line.

Total time: 2 seconds
{noformat}


> Add a 'forrest.home' property for the 'docs' target in build.xml
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2457
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2457_1_20071218.patch, HADOOP-2457_2_20071220.patch
>
>
> I propose we add a *forrest.home* property which is used as the base for the Apache Forrest installation for the _docs_ target, currently it relies on forrest being on the PATH.
> $ ant -Dforrest.home=<forrest installation> docs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.