[GitHub] [druid] clintropolis commented on pull request #11908: Improve the output of SQL explain message

[GitBox <gi...@apache.org>]

clintropolis commented on pull request #11908:
URL: https://github.com/apache/druid/pull/11908#issuecomment-971816547


   This looks nice :+1:
   
   Since this changes the output of a query, i'm +1 for adding a feature flag to allow the previous results to be returned. `PlannerConfig` would probably be the most appropriate place, maybe something like `druid.sql.useLegacyDruidExplain`? 
   
   Since this output seems totally better I think it is ok to default it to the new stuff. It might be nice to also add a context parameter so that it could be overridden per query to make it easier for developers to migrate their apps to the new output while debugging without having to set it for the entire cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org