You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/05/27 02:52:05 UTC
[GitHub] [kylin] tianhui5 opened a new pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
tianhui5 opened a new pull request #1653:
URL: https://github.com/apache/kylin/pull/1653
## Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-4999
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 commented on a change in pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
Posted by GitBox <gi...@apache.org>.
tianhui5 commented on a change in pull request #1653:
URL: https://github.com/apache/kylin/pull/1653#discussion_r640262385
##########
File path: docker/dockerfile/standalone/Dockerfile_hadoop
##########
@@ -19,8 +19,8 @@
FROM centos:7.9.2009
ENV HIVE_VERSION 1.2.1
-ENV HADOOP_VERSION 2.8.5
-ENV SPARK_VERSION 2.4.7
+ENV HADOOP_VERSION 2.7.7
+ENV SPARK_VERSION 3.1.1
Review comment:
stand alone镜像有必要支持多版本吗，如果要支持需要将tar.gz包也上传多个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] xiacongling commented on a change in pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
Posted by GitBox <gi...@apache.org>.
xiacongling commented on a change in pull request #1653:
URL: https://github.com/apache/kylin/pull/1653#discussion_r640260719
##########
File path: docker/dockerfile/standalone/Dockerfile_hadoop
##########
@@ -19,8 +19,8 @@
FROM centos:7.9.2009
ENV HIVE_VERSION 1.2.1
-ENV HADOOP_VERSION 2.8.5
-ENV SPARK_VERSION 2.4.7
+ENV HADOOP_VERSION 2.7.7
+ENV SPARK_VERSION 3.1.1
Review comment:
可以用变量控制吗？默认用 2.4.7。通过打镜像的 .sh 脚本传入。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1653:
URL: https://github.com/apache/kylin/pull/1653#issuecomment-849289397
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1653?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@ee1be8c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1653?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1653 +/- ##
======================================================
Coverage ? 24.22%
Complexity ? 4648
======================================================
Files ? 1147
Lines ? 65760
Branches ? 9684
======================================================
Hits ? 15928
Misses ? 48154
Partials ? 1678
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1653?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1653?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ee1be8c...4f4b2f1](https://codecov.io/gh/apache/kylin/pull/1653?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 closed pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
Posted by GitBox <gi...@apache.org>.
tianhui5 closed pull request #1653:
URL: https://github.com/apache/kylin/pull/1653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 commented on a change in pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
Posted by GitBox <gi...@apache.org>.
tianhui5 commented on a change in pull request #1653:
URL: https://github.com/apache/kylin/pull/1653#discussion_r640316786
##########
File path: parquet-assembly/pom.xml
##########
@@ -113,6 +113,7 @@
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <exclude>org/slf4j/**</exclude>
Review comment:
已测试，slf4j可以不删
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] xiacongling commented on a change in pull request #1653: KYLIN-4999 Make Spark3.1 compatible with hadoop2.7 and hive1.2 in standalone docker image
Posted by GitBox <gi...@apache.org>.
xiacongling commented on a change in pull request #1653:
URL: https://github.com/apache/kylin/pull/1653#discussion_r640261132
##########
File path: parquet-assembly/pom.xml
##########
@@ -113,6 +113,7 @@
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
+ <exclude>org/slf4j/**</exclude>
Review comment:
2.x 的镜像也简单测试一下吧，看移除了 sfl4j 会不会有问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org