You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by "harikrishna-patnala (via GitHub)" <gi...@apache.org> on 2025/01/21 05:17:43 UTC

Re: [I] Events not generating for BaseCmd classes [cloudstack]

harikrishna-patnala commented on issue #8771:
URL: https://github.com/apache/cloudstack/issues/8771#issuecomment-2603678049

   > In my understanding, action events in ACS are created mainly by the `@ActionEvent` annotation. For `BaseAsyncCmd` we do publish events with `Scheduled` state but that is just it. Trying to publish events for `BaseCmd` may require a lot of changes and refactoring. Would it be better to fix the specific cases where events are not generated highlighted in [#8630 (review)](https://github.com/apache/cloudstack/pull/8630#pullrequestreview-1914158484)? [@vishesh92](https://github.com/vishesh92) [@rohityadavcloud](https://github.com/rohityadavcloud) [@sureshanaparti](https://github.com/sureshanaparti)
   
   Agreed with @shwstppr comment, it is mainly addressed by ActionEvent annotation. I prefer to fix the specific cases. @vishesh92 are you fine with this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org