[GitHub] [pulsar-client-go] bschofield edited a comment on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

[GitBox <gi...@apache.org>]

bschofield edited a comment on pull request #663:
URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963433544


   @cckellogg @BewareMyPower I think this relates to your discussion in https://github.com/apache/pulsar-client-go/pull/631/files#r723350028, would appreciate it if you could take a look.
   
   I think you correctly removed the use of `c.Lock()`, but I think `c.cond.L.Lock()` should be used instead. Although it is absolutely true that the `sync.Cond` documentation says you aren't _required_ to hold the lock when broadcasting, if you don't then I think you can end up with the race observed in #662. Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org