You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/09/23 09:37:08 UTC
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/778
TAJO-1883: Keep tajo-client and its dependent modules to be 1.7 target.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1883
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/778.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #778
----
commit 65ce3d3d58742ac16ddbc04ad4e5334fb9589ece
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-09-23T07:36:43Z
TAJO-1883: Keep tajo-client and its dependent modules to be 1.7 target.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/778#issuecomment-146074464
Thank you for your reply and quick fix.
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/778#issuecomment-145454207
Sorry for late review. This patch looks good to me. Would you rebase it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/778#issuecomment-145843171
Thank you for the quick rebase. I have two questions.
* ```tajo-jdbc``` has a dependency on ```tajo-cluster-tests```, but ```tajo-cluster-tests```'s target is 1.8. Is it ok?
* Both ```tajo-client``` and ```tajo-jdbc``` have some nested dependencies. For example, ```tajo-client``` has a dependency on ```tajo-rpc-protobuf```, and which in turn it has a dependency on ```tajo-rpc-common```. In this case, I wonder that it is ok if ```tajo-rpc-common```'s target is still 1.8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/778#issuecomment-145653643
Just rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/778#issuecomment-146063152
I just fixed and rebased it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1883: Keep tajo-client and its dependent m...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/778#issuecomment-146062331
Thank you for your quick review. Here is my response:
```tajo-cluster-tests``` is ok because 1.8 has backward compatibility.
```tajo-rpc-common``` must be 1.7 too. I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---