You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Laurie Harper (JIRA)" <de...@myfaces.apache.org> on 2006/02/22 23:01:37 UTC
[jira] Created: (TOMAHAWK-155) Move ExtensionsFilter to commons so
it can be reused outside Tomahawk
Move ExtensionsFilter to commons so it can be reused outside Tomahawk
---------------------------------------------------------------------
Key: TOMAHAWK-155
URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
Project: MyFaces Tomahawk
Type: Task
Reporter: Laurie Harper
Priority: Minor
The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Created: (TOMAHAWK-155) Move ExtensionsFilter to commons
so it can be reused outside Tomahawk
Posted by Werner Punz <we...@gmx.at>.
hehe, intentional lazyness, sort of ;-)
no offence, though
Sean Schofield schrieb:
> @Werner: You should comment in the JIRA issue so we have your thoughts
> on record all in one spot.
>
> Sean
>
>> Bad idea the extension filter is a major pain for the users,
>> I would love to see to get rid of it for a phase listener
>> based approach ;-)
>>
>>
>
Re: [jira] Created: (TOMAHAWK-155) Move ExtensionsFilter to commons so it can be reused outside Tomahawk
Posted by Sean Schofield <se...@gmail.com>.
@Werner: You should comment in the JIRA issue so we have your thoughts
on record all in one spot.
Sean
> Bad idea the extension filter is a major pain for the users,
> I would love to see to get rid of it for a phase listener
> based approach ;-)
>
>
Re: [jira] Created: (TOMAHAWK-155) Move ExtensionsFilter to commons
so it can be reused outside Tomahawk
Posted by Werner Punz <we...@gmx.at>.
Laurie Harper (JIRA) schrieb:
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Task
> Reporter: Laurie Harper
> Priority: Minor
>
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
>
Bad idea the extension filter is a major pain for the users,
I would love to see to get rid of it for a phase listener
based approach ;-)
[jira] Commented: (TOMAHAWK-155) Move ExtensionsFilter to commons
so it can be reused outside Tomahawk
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=comments#action_12367465 ]
Simon Kitching commented on TOMAHAWK-155:
-----------------------------------------
Re my previous comment entry: sorry, it was Werner Punz who made that comment, in reply to Laurie.
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Wish
> Reporter: Laurie Harper
> Priority: Minor
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (TOMAHAWK-155) Move ExtensionsFilter to commons so
it can be reused outside Tomahawk
Posted by "sean schofield (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=all ]
sean schofield closed TOMAHAWK-155:
-----------------------------------
Resolution: Won't Fix
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Wish
> Reporter: Laurie Harper
> Priority: Minor
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-155) Move ExtensionsFilter to commons
so it can be reused outside Tomahawk
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=comments#action_12367464 ]
Simon Kitching commented on TOMAHAWK-155:
-----------------------------------------
Laurie Harper noted on the email list that he's against this idea, and would prefer to see a "phase listener based" approach.
I'm also against this for both Sean and Laurie's reasons.
I don't think we want to go down the track of declaring *anything* in commons a "stable public api" yet.
And I certainly would not like to do this for ExtensionsFilter/AddResource; I'm not at all convinced that this is the right general approach long term or that the current API for AddResource is the right one. It works ok for now, but isn't something that should be declared "stable" at the moment...
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Wish
> Reporter: Laurie Harper
> Priority: Minor
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (TOMAHAWK-155) Move ExtensionsFilter to commons so
it can be reused outside Tomahawk
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=all ]
Mike Kienenberger reopened TOMAHAWK-155:
----------------------------------------
I don't think you should have closed this issue, especially on such short notice.
Currently the extension filter *IS* the defacto way to do this and despite much speculation, no one has come up with anything better.
In fact, recent comments on the mailing list seem to show that there may not be any "good" ways to do this, and we're going to have to accept a less-than-perfect solution.
Adam's comments that the way ADF does this is by ignoring "the notion that <script> elements can only be in <head>"
http://mail-archives.apache.org/mod_mbox/myfaces-dev/200602.mbox/%3c6dac79b90602221123q605e9ad7r2dcd0b5674411ec2@mail.gmail.com%3e
Craig's comments that a phase listener won't work unless all of the output were done via ResponseWriter -- "likely *not* tobe true if you are using JSP pages"
http://mail-archives.apache.org/mod_mbox/myfaces-users/200602.mbox/%3cf8b39ace0602161452h7a31d803x4178b8d1f2997d13@mail.gmail.com%3e
I also think that closing this issue because we're not sure what's going to happen with "commons" is premature. Next week, the wind may blow a completely different direction. The JIRA system is the appropriate place to track Feature requests.
Whether or not the "ExtensionsFilter" is eventually implemented as a filter or as a phase listener or as something else, providing this type of functionality in a reusable way makes sense.
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Wish
> Reporter: Laurie Harper
> Priority: Minor
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-155) Move ExtensionsFilter to commons
so it can be reused outside Tomahawk
Posted by "sean schofield (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=comments#action_12367453 ]
sean schofield commented on TOMAHAWK-155:
-----------------------------------------
One issue here is that commons is not really something that we are ready to promote as an independent API. If you read the recent dev threads on this you will see how we are considering moving away from commons as a publicly released project. Eventually there might be a project dedicated to reusable stuff outside of MyFaces but that is not our short term focus.
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Task
> Reporter: Laurie Harper
> Priority: Minor
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-155) Move ExtensionsFilter to commons
so it can be reused outside Tomahawk
Posted by "Werner Punz (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=comments#action_12367480 ]
Werner Punz commented on TOMAHAWK-155:
--------------------------------------
The Extensionsfilter is just a web frontend trigger for loading resources.
The extensionsfilter is way too problematic for the end users because it enforces another entry in the web.xml.
(90% of all resource loading problems revolve around exactly this issue)
I personally would prefer a phase listener based approach, which is way less problematic, because it is more or less a snap in with its own configuration.
John Fallows pointed me out towards a project he and some other guys are doing, the so called weblet api, which is a generic resource bundeling and loading mechanism with utility and helper mechanisms for most frameworks. On the JSF side he uses a phase listener and a view handler (the view handler can be replaced with a utlity class, it is only there to keep the api as close to jsf as possible, but in fact it is only a utility class)
In the long run we should talk to the other framework makers maybe we can find a common resource bundeling and loading ground, then adding something like dojo to the codebase, could become a maven download instead of having our own resource hierarchy.
> Move ExtensionsFilter to commons so it can be reused outside Tomahawk
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-155
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-155
> Project: MyFaces Tomahawk
> Type: Wish
> Reporter: Laurie Harper
> Priority: Minor
>
> The ExtensionsFilter would be useful across projects. It could be reused by Tobago and/or ADF Faces, and would be useful in other, non-MyFaces component libraries. It would be useful if it were moved to commons to support such reuse.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira