You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/01 18:08:45 UTC

(superset) branch master updated: fix: Missing SQL Lab permission (#27361)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 8a46694ce9 fix: Missing SQL Lab permission (#27361)
8a46694ce9 is described below

commit 8a46694ce9a9ce272feac792fef8420d092a7d10
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Fri Mar 1 13:08:39 2024 -0500

    fix: Missing SQL Lab permission (#27361)
---
 superset/security/manager.py              | 1 +
 tests/integration_tests/security_tests.py | 1 +
 2 files changed, 2 insertions(+)

diff --git a/superset/security/manager.py b/superset/security/manager.py
index 30aca74eae..83e12fb2dc 100644
--- a/superset/security/manager.py
+++ b/superset/security/manager.py
@@ -756,6 +756,7 @@ class SupersetSecurityManager(  # pylint: disable=too-many-public-methods
         self.add_permission_view_menu("can_csv", "Superset")
         self.add_permission_view_menu("can_share_dashboard", "Superset")
         self.add_permission_view_menu("can_share_chart", "Superset")
+        self.add_permission_view_menu("can_sqllab", "Superset")
         self.add_permission_view_menu("can_view_query", "Dashboard")
         self.add_permission_view_menu("can_view_chart_as_table", "Dashboard")
 
diff --git a/tests/integration_tests/security_tests.py b/tests/integration_tests/security_tests.py
index f0b0b5696b..23ad938df5 100644
--- a/tests/integration_tests/security_tests.py
+++ b/tests/integration_tests/security_tests.py
@@ -1483,6 +1483,7 @@ class TestRolePermission(SupersetTestCase):
                 ("can_get", "TabStateView"),
                 ("can_get_results", "SQLLab"),
                 ("can_migrate_query", "TabStateView"),
+                ("can_sqllab", "Superset"),
                 ("can_sqllab_history", "Superset"),
                 ("can_put", "TabStateView"),
                 ("can_post", "TabStateView"),