You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/29 02:25:13 UTC

[GitHub] [superset] betodealmeida opened a new pull request, #19890: chore: upgrade SQLAlchemy

betodealmeida opened a new pull request, #19890:
URL: https://github.com/apache/superset/pull/19890

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Testing upgrading SQLAlchemy to 1.4, based on https://docs.sqlalchemy.org/en/14/changelog/migration_14.html.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] dkhwangbo commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by "dkhwangbo (via GitHub)" <gi...@apache.org>.
dkhwangbo commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1439504886

   @betodealmeida @EugeneTorap 
   Hey. This PR is not merged in 2.0.1. Any timeline to release new version this pr merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1189454016

   > @villebro @betodealmeida Do we plan to upgrade pandas to 1.4.3, pyarrow to 8.0.0, numpy to 1.23.1?
   
   We usually only upgrade dependencies if there's a need or a security issue, since it can always break things. Do you have any need for newer versions of this libraries?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1177646341

   Hi @betodealmeida, any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1291753531

   Hello @daniel-sali !
   sqlalchemy 1.4 will be in 2.0.1 release (this or next week)
   Now we have 2.0.1rc2 - https://github.com/apache/superset/blob/2.0.1rc2/CHANGELOG.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1187698782

   > Hi @betodealmeida, any updates?
   
   I'm merging this today. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] cwegener commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1441091487

   @dkhwangbo 2.1.0.rc1 has this change included. https://github.com/apache/superset/discussions/23164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #19890: chore: upgrade SQLAlchemy

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1114076865

   # [Codecov](https://codecov.io/gh/apache/superset/pull/19890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19890](https://codecov.io/gh/apache/superset/pull/19890?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9fbff73) into [master](https://codecov.io/gh/apache/superset/commit/9328053521830af7f94521897e50c76ecb15933b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9328053) will **decrease** coverage by `12.74%`.
   > The diff coverage is `56.06%`.
   
   > :exclamation: Current head 9fbff73 differs from pull request most recent head edaca03. Consider uploading reports for the commit edaca03 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #19890       +/-   ##
   ===========================================
   - Coverage   66.52%   53.77%   -12.75%     
   ===========================================
     Files        1714     1714               
     Lines       65032    65064       +32     
     Branches     6717     6722        +5     
   ===========================================
   - Hits        43260    34990     -8270     
   - Misses      20065    28362     +8297     
   - Partials     1707     1712        +5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `52.76% <30.00%> (-0.01%)` | :arrow_down: |
   | python | `56.39% <52.00%> (-26.00%)` | :arrow_down: |
   | sqlite | `?` | |
   | unit | `48.02% <46.00%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `69.23% <ø> (ø)` | |
   | [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `57.14% <ø> (ø)` | |
   | [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `44.89% <ø> (-55.11%)` | :arrow_down: |
   | [superset/commands/importers/v1/assets.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2Fzc2V0cy5weQ==) | `32.14% <ø> (-53.58%)` | :arrow_down: |
   | [superset/commands/importers/v1/examples.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2V4YW1wbGVzLnB5) | `0.00% <ø> (ø)` | |
   | [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `77.50% <ø> (-13.75%)` | :arrow_down: |
   | [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `35.29% <ø> (-63.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/gsheets.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2dzaGVldHMucHk=) | `68.68% <0.00%> (-6.83%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `35.36% <0.00%> (-50.47%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `52.38% <0.00%> (-45.21%)` | :arrow_down: |
   | ... and [295 more](https://codecov.io/gh/apache/superset/pull/19890/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19890?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19890?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9328053...edaca03](https://codecov.io/gh/apache/superset/pull/19890?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1172980814

   > Any timeline on when this might be merged ?
   
   I need to spend some time figuring out why some SQLite tests are failing. I'll give it another try this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on a diff in pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #19890:
URL: https://github.com/apache/superset/pull/19890#discussion_r874393201


##########
superset/db_engine_specs/base.py:
##########
@@ -930,7 +932,11 @@ def extract_errors(
         ]
 
     @classmethod
-    def adjust_database_uri(cls, uri: URL, selected_schema: Optional[str]) -> None:
+    def adjust_database_uri(  # pylint: disable=unused-argument
+        cls,
+        uri: URL,
+        selected_schema: Optional[str],
+    ) -> URL:

Review Comment:
   Minor comment: We may want to consider renaming and/or updating the docstrings on this and other methods 
   like `modify_url_for_impersonation` that no longer mutate the original object. For instance, `modify_url_for_impersonation` could be renamed `get_url_for_impersonation` to emphasize that it's no longer mutating the original object.



##########
superset/db_engine_specs/snowflake.py:
##########
@@ -114,13 +114,15 @@ class SnowflakeEngineSpec(PostgresBaseEngineSpec):
     @classmethod
     def adjust_database_uri(
         cls, uri: URL, selected_schema: Optional[str] = None
-    ) -> None:
+    ) -> URL:
         database = uri.database
         if "/" in uri.database:
             database = uri.database.split("/")[0]
         if selected_schema:
             selected_schema = parse.quote(selected_schema, safe="")
-            uri.database = database + "/" + selected_schema
+            uri = uri.set(database=database + "/" + selected_schema)

Review Comment:
   Maybe we could refactor this to an f-string (looks cleaner IMO):
   ```suggestion
               uri = uri.set(database=f"{database}/{selected_schema}")
   ```



##########
superset/db_engine_specs/presto.py:
##########
@@ -33,7 +33,7 @@
 from sqlalchemy import Column, literal_column, types
 from sqlalchemy.engine.base import Engine
 from sqlalchemy.engine.reflection import Inspector
-from sqlalchemy.engine.result import RowProxy
+from sqlalchemy.engine.result import Row as RowProxy

Review Comment:
   To disambiguate from the old `RowProxy` class, maybe we should rename this to `ResultRow`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on a diff in pull request #19890: chore: upgrade SQLAlchemy

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on code in PR #19890:
URL: https://github.com/apache/superset/pull/19890#discussion_r862405855


##########
tests/integration_tests/config_tests.py:
##########
@@ -137,6 +137,9 @@ def test_python_date_format_by_column_name(self):
         self.assertEqual(dms_col.python_date_format, "invalid")
 
     def test_expression_by_column_name(self):

Review Comment:
   This tests only fails in SQLite, for some reason. I decided to skip it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1308843533

   @betodealmeida maybe you know it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rxm7706 commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
rxm7706 commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1172907682

   Any timeline on when this  might be merged ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida commented on a diff in pull request #19890: chore: upgrade SQLAlchemy

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on code in PR #19890:
URL: https://github.com/apache/superset/pull/19890#discussion_r864263699


##########
tests/integration_tests/config_tests.py:
##########
@@ -137,6 +137,9 @@ def test_python_date_format_by_column_name(self):
         self.assertEqual(dms_col.python_date_format, "invalid")
 
     def test_expression_by_column_name(self):

Review Comment:
   I was not able to reproduce the failing SQLite tests no matter what — I even tried https://github.com/nektos/act and running the containers manually. So I rewrote them as proper unit tests. :-P



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] daniel-sali commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
daniel-sali commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1291715026

   Hi @betodealmeida,
   
   Do you have a timeline for when this will be released? I'm asking because we use Superset with Snowflake, and snowflake-sqlalchemy requires sqlalchemy 1.4 or newer, and older versions limit the snowflake-connector-python Python driver version to an unsupported old version. 
   Unfortunately, this change is not in the latest 1.5 and 2.0 Superset releases yet :-(
   
   Thanks,
   Daniel


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] betodealmeida merged pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
betodealmeida merged PR #19890:
URL: https://github.com/apache/superset/pull/19890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1188636116

   @villebro @betodealmeida Do we plan upgrade pandas to 1.4.3, pyarrow to 8.0.0, numpy to 1.23.1?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] daniel-sali commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
daniel-sali commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1291755844

   Thank you @EugeneTorap for the quick reply, best of luck with the new release, will give it a go once it's out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] daniel-sali commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by GitBox <gi...@apache.org>.
daniel-sali commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1308825253

   Hi @EugeneTorap, I don't see the change in the 2.0.1 RC2. I'm checking setup.py for the sqlalchemy dependency version, and it's still specified as < 1.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #19890: chore: upgrade SQLAlchemy to 1.4

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #19890:
URL: https://github.com/apache/superset/pull/19890#issuecomment-1439545706

   Hi @dkhwangbo!
   It will be merged in 2.1.0 version (in 2-3 months)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org