You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/30 03:04:00 UTC
[jira] [Commented] (THRIFT-3600) Make TTwisted server send
exception on unexpected handler error
[ https://issues.apache.org/jira/browse/THRIFT-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272086#comment-16272086 ]
ASF GitHub Bot commented on THRIFT-3600:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1424
THRIFT-3600 Make TTwisted server send exception on unexpected handler…
… error
(resubmitting for nsuke)
Client: py
This closes #838
This closes #1424
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-3600-take-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1424
----
commit 99863e62b73236d1cd186bdd8b1cb36b8ac83406
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-02-10T10:42:19Z
THRIFT-3600 Make TTwisted server send exception on unexpected handler error
Client: py
This closes #838
This closes #1424
----
> Make TTwisted server send exception on unexpected handler error
> ---------------------------------------------------------------
>
> Key: THRIFT-3600
> URL: https://issues.apache.org/jira/browse/THRIFT-3600
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
>
> When unspecified exception occurs inside handler, TTwisted server disconnects the client.
> Many other languages and non TTwisted/Tornado servers sends TApplicationException in such cases.
> There is even a test case that tries to assert this behavior for TTwisted but the test is broken in a way it fails to detect the failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)