You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/17 17:21:54 UTC
Review Request 63081: Format constraints on Task Config Summary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63081/
-----------------------------------------------------------
Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Format constraints on Task Config Summary
Diffs
-----
ui/src/main/js/components/TaskConfigSummary.js 69b1a40cc4419d5aecb3da7c8bcfb549b789dc7f
ui/src/main/sass/components/_job-page.scss 8523fcf4c917b46c9d514325f073bd5788798156
Diff: https://reviews.apache.org/r/63081/diff/1/
Testing
-------
File Attachments
----------------
Constraint fix
https://reviews.apache.org/media/uploaded/files/2017/10/17/020c1035-0e54-42ad-b685-17130e370e51__Screen_Shot_2017-10-17_at_10.20.52_AM.png
Thanks,
David McLaughlin
Re: Review Request 63081: Format constraints on Task Config Summary
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63081/#review188373
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Oct. 17, 2017, 10:21 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63081/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:21 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Format constraints on Task Config Summary
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js 69b1a40cc4419d5aecb3da7c8bcfb549b789dc7f
> ui/src/main/sass/components/_job-page.scss 8523fcf4c917b46c9d514325f073bd5788798156
>
>
> Diff: https://reviews.apache.org/r/63081/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Constraint fix
> https://reviews.apache.org/media/uploaded/files/2017/10/17/020c1035-0e54-42ad-b685-17130e370e51__Screen_Shot_2017-10-17_at_10.20.52_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63081: Format constraints on Task Config Summary
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63081/#review188344
-----------------------------------------------------------
Ship it!
Master (5b72398) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 17, 2017, 5:21 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63081/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:21 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Format constraints on Task Config Summary
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js 69b1a40cc4419d5aecb3da7c8bcfb549b789dc7f
> ui/src/main/sass/components/_job-page.scss 8523fcf4c917b46c9d514325f073bd5788798156
>
>
> Diff: https://reviews.apache.org/r/63081/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Constraint fix
> https://reviews.apache.org/media/uploaded/files/2017/10/17/020c1035-0e54-42ad-b685-17130e370e51__Screen_Shot_2017-10-17_at_10.20.52_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63081: Format constraints on Task Config Summary
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63081/#review188346
-----------------------------------------------------------
Ship it!
Ship It!
- Kai Huang
On Oct. 17, 2017, 5:21 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63081/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:21 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Format constraints on Task Config Summary
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js 69b1a40cc4419d5aecb3da7c8bcfb549b789dc7f
> ui/src/main/sass/components/_job-page.scss 8523fcf4c917b46c9d514325f073bd5788798156
>
>
> Diff: https://reviews.apache.org/r/63081/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Constraint fix
> https://reviews.apache.org/media/uploaded/files/2017/10/17/020c1035-0e54-42ad-b685-17130e370e51__Screen_Shot_2017-10-17_at_10.20.52_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63081: Format constraints on Task Config Summary
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63081/#review188337
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On Oct. 17, 2017, 5:21 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63081/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:21 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Format constraints on Task Config Summary
>
>
> Diffs
> -----
>
> ui/src/main/js/components/TaskConfigSummary.js 69b1a40cc4419d5aecb3da7c8bcfb549b789dc7f
> ui/src/main/sass/components/_job-page.scss 8523fcf4c917b46c9d514325f073bd5788798156
>
>
> Diff: https://reviews.apache.org/r/63081/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Constraint fix
> https://reviews.apache.org/media/uploaded/files/2017/10/17/020c1035-0e54-42ad-b685-17130e370e51__Screen_Shot_2017-10-17_at_10.20.52_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>