[jira] [Closed] (FLINK-7069) Catch exceptions for each reporter separately

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-7069.
-----------------------------------
    Resolution: Fixed

1.3: 8bfd1206f36470afd6d23798ec9f19b7e147df4b
1.4: ee789583d3a7a9ee1bda5b9f3b0dd388279b9ad5

> Catch exceptions for each reporter separately
> ---------------------------------------------
>
>                 Key: FLINK-7069
>                 URL: https://issues.apache.org/jira/browse/FLINK-7069
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.3.1, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.4.0, 1.3.2
>
>
> The metric system can be effectively disabled by a reporter that throws exceptions whenever it is notified of adding metrics.
> The reason is that the catching of exceptions isn't granular enough, as this peace of psude code shows:
> {code}
> addMetric(metric):
> 	try
> 		for reporter in reporters:
> 			reporter.addMetric(metric)
> 		metricQueryService.addMetric(metric)
> 	catch (e)
> 		logError(e)	
> {code}
> If a reporter throws an exception we never even attempt the other reporters, not notify the MQS which disabled metrics in the WebUI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)