You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/02/12 07:48:07 UTC
[jira] Created: (JCR-1371) [PATCH] unnecessary synchronized
collections used only in thread safe way
[PATCH] unnecessary synchronized collections used only in thread safe way
-------------------------------------------------------------------------
Key: JCR-1371
URL: https://issues.apache.org/jira/browse/JCR-1371
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-core
Affects Versions: 1.4.1
Reporter: Dave Brosius
Priority: Minor
Fix For: 1.4.1
Attachments: local_synchronized_collections.patch
NodeTypeReader uses Vector in only a local variable thread safe way. Thus the synchronized value of Vector is not needed, and just slowing the code down for nothing. this patch switches the collections to ArrayLists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1371) [PATCH] unnecessary synchronized
collections used only in thread safe way
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568009#action_12568009 ]
Tobias Bocanegra commented on JCR-1371:
---------------------------------------
well, of course unsync. collections would be better. but how often is the nodetype reader executed?
only once during startup and this saves you maybe 1msec :-)
> [PATCH] unnecessary synchronized collections used only in thread safe way
> -------------------------------------------------------------------------
>
> Key: JCR-1371
> URL: https://issues.apache.org/jira/browse/JCR-1371
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4.1
> Reporter: Dave Brosius
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: local_synchronized_collections.patch
>
>
> NodeTypeReader uses Vector in only a local variable thread safe way. Thus the synchronized value of Vector is not needed, and just slowing the code down for nothing. this patch switches the collections to ArrayLists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1371) [PATCH] unnecessary synchronized
collections used only in thread safe way
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1371:
-------------------------------
Priority: Trivial (was: Minor)
Affects Version/s: (was: 1.4.1)
Fix Version/s: (was: 1.4.1)
1.5
> [PATCH] unnecessary synchronized collections used only in thread safe way
> -------------------------------------------------------------------------
>
> Key: JCR-1371
> URL: https://issues.apache.org/jira/browse/JCR-1371
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: local_synchronized_collections.patch
>
>
> NodeTypeReader uses Vector in only a local variable thread safe way. Thus the synchronized value of Vector is not needed, and just slowing the code down for nothing. this patch switches the collections to ArrayLists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1371) [PATCH] unnecessary synchronized
collections used only in thread safe way
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Guggisberg resolved JCR-1371.
------------------------------------
Resolution: Fixed
fixed as suggested (svn r627503)
thanks!
> [PATCH] unnecessary synchronized collections used only in thread safe way
> -------------------------------------------------------------------------
>
> Key: JCR-1371
> URL: https://issues.apache.org/jira/browse/JCR-1371
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4.1
> Reporter: Dave Brosius
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: local_synchronized_collections.patch
>
>
> NodeTypeReader uses Vector in only a local variable thread safe way. Thus the synchronized value of Vector is not needed, and just slowing the code down for nothing. this patch switches the collections to ArrayLists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1371) [PATCH] unnecessary synchronized
collections used only in thread safe way
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated JCR-1371:
------------------------------
Attachment: local_synchronized_collections.patch
> [PATCH] unnecessary synchronized collections used only in thread safe way
> -------------------------------------------------------------------------
>
> Key: JCR-1371
> URL: https://issues.apache.org/jira/browse/JCR-1371
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 1.4.1
> Reporter: Dave Brosius
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: local_synchronized_collections.patch
>
>
> NodeTypeReader uses Vector in only a local variable thread safe way. Thus the synchronized value of Vector is not needed, and just slowing the code down for nothing. this patch switches the collections to ArrayLists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.