[GitHub] [cordova-plugin-contacts] TheBosZ opened a new pull request #211: (android) Make the phone number searching smarter

[GitBox <gi...@apache.org>]

TheBosZ opened a new pull request #211: (android) Make the phone number searching smarter
URL: https://github.com/apache/cordova-plugin-contacts/pull/211
 
 
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   The phone number searching in Android is very poor by default. The phone number needs to be an exact match (or contain only a portion) of the number.
   
   This doesn't work with something like caller ID. For example, the Android caller ID will report the number with a "plus" (+) followed by the country code and then the number with no spaces.
   
   As an example, if I get a phone call from Jenny, her number will show up like "+15058675409". But in my contacts list, I have her number as "(505) 867-5309".
   
   The default search method won't return Jenny's contact information in this case. 
   
   ### Description
   This change uses the method described on this [Stack Overflow post](https://stackoverflow.com/a/7967182/1734975). This will allow the search to find Jenny's contact information.
   
   It only changes the search if the user is searching by phone number (the fields sent to search have "phoneNumbers" in it), otherwise the search stays the same.
   
   ### Testing
   Tested by searching with and without the phone number.
   
   ### Checklist
   
   - [x ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org